From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795310931; b=m66NXP9ii3EUAQP+saKjPuuVOVe8TF6ElRXmofSdVh/nKZNaAwUNoCYLSuFHxESiL5bT Qs2Hv28Vmjy/ek11R5OKYSenFuuT8cgA9oJemLbE/00rBhKtbR/ImklUa+ZFLn5RV34kJ tERQAKzfDB6Oy5mEPjnrzuBUEoBINQHqIdrNwyehcleGLKk6H4pzrkKtRAOie7EJiBafI 8TzI6pWhhc2hEy7de/TF6j+Fdukkt7lEhQmcwVXgn62akVDQZio84YErQ/B/5M1rZh90+ i0OYn+k9xwROjbmIsYQr/KYpVRPDu+rPS2RFp7jeVXxaa37IOhdwNUO2lfkEs8m/Myw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795310931; h=DMARC-Filter:Received:Received:X-Authority-Analysis:DKIM-Signature: Received:Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To:X-AntiAbuse:X-AntiAbuse: X-AntiAbuse:X-AntiAbuse:X-AntiAbuse:X-BWhitelist:X-Source-IP: X-Source-L:X-Exim-ID:X-Source:X-Source-Args:X-Source-Dir: X-Source-Sender:X-Source-Auth:X-Email-Count:X-Org:X-Source-Cap: X-Local-Domain:X-CMAE-Envelope; bh=j7wV5xYsKk+AnKzewK6ED1DY0tL9Fq/vDgt6ZBEAmrk=; b=2nP7dbE4MB1G/+70vujAUYqtXlJ0REbzDTGyEIRxndfi8iPFOMEd0PGa2+mx90ifgxpb 7wLXn3t5XkY0AQ05boxS83Y/poaXutEwW1ZOMjbYcwvuZEiWZwqQol/SbuqQopF0P3a9/ Ln4VykNQmtw36nYJw1nsQoGcpIRAScluatxbca2bXouJ9oMlkmBd+jvaUIeTmh+uTJfPi +Cmcv5D4TUSZJKhDkuqzcm9Iw0coWt5rBkd5KvO4UDBKExUfgJhY4RvZrcyiYDHTFEagE aQu50FZtDrpysTSwcUgLxOdpghGv2fnho7SabSA6YNvG+yWWAXo1mYqZ/se7ZELSKiw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=roeck-us.net; spf=fail smtp.mailfrom=roeck-us.net; dkim=pass header.d=roeck-us.net header.i=@roeck-us.net header.a=rsa-sha256 header.s=default header.b=g229YHOB; arc=none smtp.remote-ip=35.89.44.33 Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB2DC606A320 for ; Sun, 22 Nov 2026 01:28:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org BB2DC606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=roeck-us.net header.i=@roeck-us.net header.a=rsa-sha256 header.s=default header.b=g229YHOB Received: from eig-obgw-5004b.ext.cloudfilter.net ([10.0.29.208]) by cmsmtp with ESMTPS id Uht5xM8XBAR1iUwNuxOuZH; Sun, 22 Nov 2026 01:28:50 +0000 Received: from 162-215-252-36.unifiedlayer.com ([208.91.199.152]) by cmsmtp with ESMTPS id UwNtx9N8ruJrPUwNtxQliZ; Sun, 22 Nov 2026 01:28:50 +0000 X-Authority-Analysis: v=2.4 cv=WLZ/XmsR c=1 sm=1 tr=0 ts=6b024552 a=QNED+QcLUkoL9qulTODnwA==:117 a=2cfIYNtKkjgZNaOwnGXpGw==:17 a=kj9zAlcOel0A:10 a=zJRp6_cAMcgA:10 a=M0FbrtG7MMAA:10 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=1pp0S3YwmL9lSNfLDwgA:9 a=CjuIK1q_8ugA:10 a=KPbNTLLc3YvdawN95zVk:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=In-Reply-To:Content-Type:MIME-Version:References :Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=j7wV5xYsKk+AnKzewK6ED1DY0tL9Fq/vDgt6ZBEAmrk=; b=g229YHOB7tCg4Z/SwqMpPNGxUW q9a9a3lR9qOm0D75rmzC8VvgTIasiwDBGOxUuSbtvGsj4OkaQL3epxwaRaOEAeRzGodMaF2+Al4Xs 0GQ7DMM3G8KIUUtyS1VtVywo0GHyHJV45QCZUH1J4FQHvW8FEO2exYG4y8ooBWGJDNGpqGIX7n3KK GujjwKUoTMEBxVdDw4UUmE5aruOzchol+1RMY3CAZa/iYJFD5wkAGxnNYb1qp1SunsLXNZjfeWP/d kdjiLh6KQEtqUPQXCEhWydzOikLmY58+0AfL+pZHasEIlI5bNJUYcO6ovVga8GngYP7SWRAk/8K1S y/XLCrLw==; Received: from 108-223-40-66.lightspeed.sntcca.sbcglobal.net ([108.223.40.66]:46818 helo=server.roeck-us.net) by bh-25.webhostbox.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xUwNt-00000000mlw-17XS; Sun, 22 Nov 2026 06:58:49 +0530 Date: Sat, 21 Nov 2026 17:28:48 -0800 From: Guenter Roeck To: David Yang Cc: linux-watchdog@vger.kernel.org, stable@vger.kernel.org, Wim Van Sebroeck , Jongsung Kim , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] watchdog: sp805: re-enable the clock in the restart handler Message-ID: References: <20261121204528.2435533-1-mmyangfl@gmail.com> X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261121204528.2435533-1-mmyangfl@gmail.com> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-BWhitelist: no X-Source-IP: 108.223.40.66 X-Source-L: No X-Exim-ID: 1xUwNt-00000000mlw-17XS X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 108-223-40-66.lightspeed.sntcca.sbcglobal.net (server.roeck-us.net) [108.223.40.66]:46818 X-Source-Auth: guenter@roeck-us.net X-Email-Count: 10 X-Org: HG=direseller_whb_net_legacy;ORG=directi; X-Source-Cap: cm9lY2s7YWN0aXZzdG07YmgtMjUud2ViaG9zdGJveC5uZXQ= X-Local-Domain: yes X-CMAE-Envelope: MS4xfBE5RLtbdWEIYhb9wRGN/7tz1ERYLcl18cXxIp7LCvipm1tJwK156goQryrXOszH9lAhF6iHxhfSSnEdLm1SC7OwhgH1yXY4cvDZqw3d0wsHjDL/ejCz JFmlpcKvDdk43hH5SaDAy6xtp2iGMTGlG5fBRB3h0DZbIEdBFVXZOGIK5ZX0c55xoKJU5F2N1YSUs5gC92cXEgOu373Z+RkqT3F2V8seXzAEV0pIlCHRyQok On Sun, Nov 22, 2026 at 04:45:25AM +0800, David Yang wrote: > wdt_restart() fail to reboot the system if the watchdog counter clock > was previously disabled: If userspace cleanly stops the watchdog, the > core calls wdt_disable() which disables wdt->clk. No reset comes. > > Re-enable the clock in it as in npcm_wdt. The watchdog .restart() > callback runs in atomic context: get the clock with > devm_clk_get_optional_prepared() at probe time and keep it prepared for > the lifetime of the driver, so the restart handler only needs > clk_enable(), which is safe in atomic context. > > Link: https://lore.kernel.org/r/20260911031916.A8E051F000FF@smtp.kernel.org > Fixes: 6c5c0d48b686 ("watchdog: sp805: add restart handler") > Cc: stable@vger.kernel.org > Signed-off-by: David Yang Applied. Thanks, Guenter