From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Kuangyi Chiang <ki.chiang65@gmail.com>,
mathias.nyman@intel.com, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2 2/5] xhci: Don't issue Reset Device command to Etron xHCI host
Date: Wed, 30 Oct 2024 14:58:47 +0200 [thread overview]
Message-ID: <e156aec9-a30a-4f90-a158-634cb0ecea98@linux.intel.com> (raw)
In-Reply-To: <20241028025337.6372-3-ki.chiang65@gmail.com>
On 28.10.2024 4.53, Kuangyi Chiang wrote:
> Sometimes the hub driver does not recognize the USB device connected
> to the external USB2.0 hub when the system resumes from S4.
>
> After the SetPortFeature(PORT_RESET) request is completed, the hub
> driver calls the HCD reset_device callback, which will issue a Reset
> Device command and free all structures associated with endpoints
> that were disabled.
>
> This happens when the xHCI driver issue a Reset Device command to
> inform the Etron xHCI host that the USB device associated with a
> device slot has been reset. Seems that the Etron xHCI host can not
> perform this command correctly, affecting the USB device.
>
> To work around this, the xHCI driver should obtain a new device slot
> with reference to commit 651aaf36a7d7 ("usb: xhci: Handle USB transaction
> error on address command"), which is another way to inform the Etron
> xHCI host that the USB device has been reset.
>
> Add a new XHCI_ETRON_HOST quirk flag to invoke the workaround in
> xhci_discover_or_reset_device().
>
> Fixes: 2a8f82c4ceaf ("USB: xhci: Notify the xHC when a device is reset.")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Kuangyi Chiang <ki.chiang65@gmail.com>
Ok, I see, this patch depends on previous one, that's why it had the tags
Added this as well
Thanks
Mathias
next prev parent reply other threads:[~2024-10-30 12:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241028025337.6372-1-ki.chiang65@gmail.com>
2024-10-28 2:53 ` [PATCH v2 1/5] xhci: Combine two if statements for Etron xHCI host Kuangyi Chiang
2024-10-30 12:04 ` Mathias Nyman
2024-11-01 2:30 ` Kuangyi Chiang
2024-11-01 12:57 ` Mathias Nyman
2024-10-28 2:53 ` [PATCH v2 2/5] xhci: Don't issue Reset Device command to " Kuangyi Chiang
2024-10-30 12:58 ` Mathias Nyman [this message]
2024-10-28 2:53 ` [PATCH v2 3/5] xhci: Fix control transfer error on " Kuangyi Chiang
2024-10-28 2:53 ` [PATCH v2 4/5] xhci: Don't perform Soft Retry for " Kuangyi Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e156aec9-a30a-4f90-a158-634cb0ecea98@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ki.chiang65@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox