From: James Smart <james.smart@broadcom.com>
To: Sagi Grimberg <sagi@grimberg.me>, linux-nvme@lists.infradead.org
Cc: Israel Rukshin <israelr@mellanox.com>,
stable@vger.kernel.org, Keith Busch <kbusch@kernel.org>,
Max Gurtovoy <maxg@mellanox.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme: Revert: Fix controller creation races with teardown flow
Date: Tue, 1 Sep 2020 17:01:50 -0700 [thread overview]
Message-ID: <e1df5a4a-702e-eea0-d52d-ec5f0de1422d@broadcom.com> (raw)
In-Reply-To: <7e78b2e6-d103-23a1-a9ab-d12336a9c089@grimberg.me>
On 9/1/2020 3:01 PM, Sagi Grimberg wrote:
>
> But you also return back &ctrl->ctrl, that is another dereference, and
> what will make ctrl to be an ERR_PTR?
>
> Anyway, we should probably come up with something more robust...
ok
>
>> not sure what you are asking. if it's how long to fail the creation
>> of a new association - it's at least 60s (an admin command timeout).
>
> That's the worst case (admin command timeout), but is it the most common
> case?
>
Yes - as it currently corresponds to packet drops. command failures are
rare. FC has a feature to speed this up but it's not widely implemented yet.
> Would making the timeouts shorter in the initial connect make sense?
> Just throwing out ideas...
I'd enjoy a reduced time regardless. But the main concern is how long we
have the systemd processes blocked.
-- james
next prev parent reply other threads:[~2020-09-02 0:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 19:01 [PATCH] nvme: Revert: Fix controller creation races with teardown flow James Smart
2020-08-28 19:08 ` Sagi Grimberg
2020-08-28 20:24 ` James Smart
2020-08-28 23:59 ` Sagi Grimberg
2020-08-31 22:26 ` James Smart
2020-08-31 23:15 ` Sagi Grimberg
2020-09-01 15:39 ` James Smart
2020-09-01 22:01 ` Sagi Grimberg
2020-09-02 0:01 ` James Smart [this message]
2020-09-08 17:47 ` Christoph Hellwig
2020-09-08 17:47 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2020-08-28 19:01 James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1df5a4a-702e-eea0-d52d-ec5f0de1422d@broadcom.com \
--to=james.smart@broadcom.com \
--cc=hch@lst.de \
--cc=israelr@mellanox.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox