From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=109.224.244.120 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795220035; b=c8SbTWK6ye4jzlGJjt15Bt6TtH1CLWvcaOqG2sUo52Ymn3xz76wXjwVMUHdb/H0v/MID nCLzm+r0SXOZD4NQV3WwNCgi2Zei9lXzWChIW/SjNpyMoMvLqC3C5Yb1zCXWA+O0iKZWq s8dSazV45oFRXnFBNQ3VfEQLFTZsBOkt6lE93TWWCiAYZ1PtIAakMMDqUNOolCOboivTe Ek0qFp4eM/2+Uurns8dz/MXFsq5Qg0Ckc9/waZ7+03ZHbgeB86LfgWRUZnoeX83R6rLpu g1xR67xo0v8SWzRb1cJWHBy6tZBlciejVCAWM8CKOEUQJiV1rpg7OEEn/DGdou/KiHw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795220035; h=DMARC-Filter:DKIM-Signature:Date:To:From:Subject:Message-ID: Feedback-ID:X-Pm-Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding; bh=u8o0MhODnAqAqwtUdQcJT9bvZ0LB8lSqCcD3EtEcsNQ=; b=gpdA+4HbI31yL5QtYqZqmVq1bSoPGiuqvHBbZPmZpKxd5T48TYimQOzI3HozLI/WBugX uAsphQ08B6MXkjntsoFOqXaiPg0ZzcKf6H5oTMaoOTJk4OvFUVw1GRezejh4KlrYlJ1LA 8P5dd+kdkGueHAyfh4SlNIsXnVltH1TKynJX2fm16/5mp+PliUGfw4uQ414VIoCjwL0aD knIKyLLXpbViwzbZnnDcjOc/rUSVmfFNlA3T+MiYByc2MrLjFO+UOue4AzRbEoDm/Ooc6 8M6p4BIaBuhPta5Ool3ikTKUaCHih1hBn2oeCjA/1MaOC3FOh35iR95bh5OJRJHTpHw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=innora.ai; spf=pass smtp.mailfrom=innora.ai; dkim=pass header.d=innora.ai header.i=@innora.ai header.a=rsa-sha256 header.s=protonmail3 header.b=TSuLaj4R; arc=none smtp.remote-ip=109.224.244.120 Received: from mail-244120.protonmail.ch (mail-244120.protonmail.ch [109.224.244.120]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40D3C606A6A6 for ; Sat, 21 Nov 2026 00:13:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 40D3C606A6A6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=innora.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=innora.ai Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=innora.ai header.i=@innora.ai header.a=rsa-sha256 header.s=protonmail3 header.b=TSuLaj4R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=innora.ai; s=protonmail3; t=1795220028; x=1795479228; bh=u8o0MhODnAqAqwtUdQcJT9bvZ0LB8lSqCcD3EtEcsNQ=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=TSuLaj4RBktrIIMPLIPVPAzdEtXt/oBVXGJODf80wyyIrn72U0SUXNb1kELn9aIgL EIteA3yqDTjQzX/mYfGCkcOa+8PKxpsrXUkW8sYhFUPJalOdePQh4r+HV/MO9NeaNr A3XGJ5jO5r5d3Tdx/fBbAziM42YianOt6nM/9oFKntAzqajEq+XSPbIJmbmg6tUibG D71rmHkypaRLN3TA5wn4lBSo1HGMCyvSmIFjx284t+q2iubJ44kIjKlOSmuxu/w6S/ GV6McUb1Qfvxs+HwVLCDt+F/6vDwc/i8+5a0PprnIcHoJZ6vLdz9PGGuY3CO4K4EC/ BwHneIhZypyLg== Date: Sat, 21 Nov 2026 00:13:42 +0000 To: stable@vger.kernel.org From: Feng Ning Subject: [PATCH 6.18.y] staging: media: atomisp: use array3_size() for overflow-safe allocation Message-ID: Feedback-ID: 140578448:user:proton X-Pm-Message-ID: 6f2df25f75feadf2eb1184c507bd8aa02fe7a515 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [ Upstream commit d178c7ca8fefc28115d35b94c3b1f4d653e34182 ] Replace open-coded width * height * sizeof() multiplications with array3_size() to prevent integer overflow in buffer allocations. The atomisp driver computes DVS, morphing table, shading table and statistics buffer sizes using unchecked arithmetic. When the table dimensions are large, the product can silently wrap, causing kvmalloc() to allocate an undersized buffer. array3_size() saturates to SIZE_MAX on overflow, so kvmalloc() returns NULL instead of succeeding with too few bytes. Backport note: these three files do not include in this tree yet, so the include is added here. No other changes were made. Signed-off-by: Feng Ning Signed-off-by: Sakari Ailus --- diff --git a/drivers/staging/media/atomisp/pci/sh_css_param_dvs.c b/drivers= /staging/media/atomisp/pci/sh_css_param_dvs.c index 7fa4aab35..3fea1df17 100644 --- a/drivers/staging/media/atomisp/pci/sh_css_param_dvs.c +++ b/drivers/staging/media/atomisp/pci/sh_css_param_dvs.c @@ -4,6 +4,8 @@ * Copyright (c) 2015, Intel Corporation. */ =20 +#include + #include "sh_css_param_dvs.h" #include #include @@ -49,7 +51,7 @@ alloc_dvs_6axis_table(const struct ia_css_resolution *fra= me_res, =09=09} =20 =09=09/* Generate Y buffers */ -=09=09dvs_config->xcoords_y =3D kvmalloc(width_y * height_y * sizeof(uint3= 2_t), +=09=09dvs_config->xcoords_y =3D kvmalloc(array3_size(width_y, height_y, si= zeof(uint32_t)), =09=09=09=09=09=09 GFP_KERNEL); =09=09if (!dvs_config->xcoords_y) { =09=09=09IA_CSS_ERROR("out of memory"); @@ -57,7 +59,7 @@ alloc_dvs_6axis_table(const struct ia_css_resolution *fra= me_res, =09=09=09goto exit; =09=09} =20 -=09=09dvs_config->ycoords_y =3D kvmalloc(width_y * height_y * sizeof(uint3= 2_t), +=09=09dvs_config->ycoords_y =3D kvmalloc(array3_size(width_y, height_y, si= zeof(uint32_t)), =09=09=09=09=09=09 GFP_KERNEL); =09=09if (!dvs_config->ycoords_y) { =09=09=09IA_CSS_ERROR("out of memory"); @@ -68,7 +70,8 @@ alloc_dvs_6axis_table(const struct ia_css_resolution *fra= me_res, =09=09/* Generate UV buffers */ =09=09IA_CSS_LOG("UV W %d H %d", width_uv, height_uv); =20 -=09=09dvs_config->xcoords_uv =3D kvmalloc(width_uv * height_uv * sizeof(ui= nt32_t), +=09=09dvs_config->xcoords_uv =3D kvmalloc(array3_size(width_uv, height_uv, +=09=09=09=09=09=09=09 sizeof(uint32_t)), =09=09=09=09=09=09 GFP_KERNEL); =09=09if (!dvs_config->xcoords_uv) { =09=09=09IA_CSS_ERROR("out of memory"); @@ -76,7 +79,8 @@ alloc_dvs_6axis_table(const struct ia_css_resolution *fra= me_res, =09=09=09goto exit; =09=09} =20 -=09=09dvs_config->ycoords_uv =3D kvmalloc(width_uv * height_uv * sizeof(ui= nt32_t), +=09=09dvs_config->ycoords_uv =3D kvmalloc(array3_size(width_uv, height_uv, +=09=09=09=09=09=09=09 sizeof(uint32_t)), =09=09=09=09=09=09 GFP_KERNEL); =09=09if (!dvs_config->ycoords_uv) { =09=09=09IA_CSS_ERROR("out of memory"); diff --git a/drivers/staging/media/atomisp/pci/sh_css_param_shading.c b/dri= vers/staging/media/atomisp/pci/sh_css_param_shading.c index 513e272f2..bcd6d2a3f 100644 --- a/drivers/staging/media/atomisp/pci/sh_css_param_shading.c +++ b/drivers/staging/media/atomisp/pci/sh_css_param_shading.c @@ -4,6 +4,8 @@ * Copyright (c) 2015, Intel Corporation. */ =20 +#include + #include #include =20 @@ -339,7 +341,8 @@ ia_css_shading_table_alloc( =09me->fraction_bits =3D 0; =09for (i =3D 0; i < IA_CSS_SC_NUM_COLORS; i++) { =09=09me->data[i] =3D -=09=09 kvmalloc(width * height * sizeof(*me->data[0]), +=09=09 kvmalloc(array3_size(width, height, +=09=09=09=09=09 sizeof(*me->data[0])), =09=09=09 GFP_KERNEL); =09=09if (!me->data[i]) { =09=09=09unsigned int j; diff --git a/drivers/staging/media/atomisp/pci/sh_css_params.c b/drivers/st= aging/media/atomisp/pci/sh_css_params.c index 11d62313c..f83e3a241 100644 --- a/drivers/staging/media/atomisp/pci/sh_css_params.c +++ b/drivers/staging/media/atomisp/pci/sh_css_params.c @@ -4,6 +4,8 @@ * Copyright (c) 2015, Intel Corporation. */ =20 +#include + #include =20 #include "gdc_device.h"=09=09/* gdc_lut_store(), ... */ @@ -1381,11 +1383,11 @@ struct ia_css_morph_table *ia_css_morph_table_alloc= ate( =09} =20 =09for (i =3D 0; i < IA_CSS_MORPH_TABLE_NUM_PLANES; i++) { -=09=09me->coordinates_x[i] =3D kvmalloc(height * width * -=09=09=09=09=09=09sizeof(*me->coordinates_x[i]), +=09=09me->coordinates_x[i] =3D kvmalloc(array3_size(height, width, +=09=09=09=09=09=09=09 sizeof(*me->coordinates_x[i])), =09=09=09=09=09=09GFP_KERNEL); -=09=09me->coordinates_y[i] =3D kvmalloc(height * width * -=09=09=09=09=09=09sizeof(*me->coordinates_y[i]), +=09=09me->coordinates_y[i] =3D kvmalloc(array3_size(height, width, +=09=09=09=09=09=09=09 sizeof(*me->coordinates_y[i])), =09=09=09=09=09=09GFP_KERNEL); =20 =09=09if ((!me->coordinates_x[i]) || @@ -4206,13 +4208,17 @@ ia_css_dvs_statistics_allocate(const struct ia_css_= dvs_grid_info *grid) =09=09goto err; =20 =09me->grid =3D *grid; -=09me->hor_proj =3D kvmalloc(grid->height * IA_CSS_DVS_NUM_COEF_TYPES * -=09=09=09=09sizeof(*me->hor_proj), GFP_KERNEL); +=09me->hor_proj =3D kvmalloc(array3_size(grid->height, +=09=09=09=09=09 IA_CSS_DVS_NUM_COEF_TYPES, +=09=09=09=09=09=09sizeof(*me->hor_proj)), +=09=09=09=09GFP_KERNEL); =09if (!me->hor_proj) =09=09goto err; =20 -=09me->ver_proj =3D kvmalloc(grid->width * IA_CSS_DVS_NUM_COEF_TYPES * -=09=09=09=09sizeof(*me->ver_proj), GFP_KERNEL); +=09me->ver_proj =3D kvmalloc(array3_size(grid->width, +=09=09=09=09=09 IA_CSS_DVS_NUM_COEF_TYPES, +=09=09=09=09=09=09sizeof(*me->ver_proj)), +=09=09=09=09GFP_KERNEL); =09if (!me->ver_proj) =09=09goto err; =20 @@ -4479,24 +4485,26 @@ ia_css_dvs2_6axis_config_allocate(const struct ia_c= ss_stream *stream) =09=09=09=09 params->pipe_dvs_6axis_config[IA_CSS_PIPE_ID_VIDEO]->heigh= t_uv; =09IA_CSS_LOG("table Y: W %d H %d", width_y, height_y); =09IA_CSS_LOG("table UV: W %d H %d", width_uv, height_uv); -=09dvs_config->xcoords_y =3D kvmalloc(width_y * height_y * sizeof(uint32_t= ), +=09dvs_config->xcoords_y =3D kvmalloc(array3_size(width_y, height_y, +=09=09=09=09=09=09 sizeof(uint32_t)), =09=09=09=09=09 GFP_KERNEL); =09if (!dvs_config->xcoords_y) =09=09goto err; =20 -=09dvs_config->ycoords_y =3D kvmalloc(width_y * height_y * sizeof(uint32_t= ), +=09dvs_config->ycoords_y =3D kvmalloc(array3_size(width_y, height_y, +=09=09=09=09=09=09 sizeof(uint32_t)), =09=09=09=09=09 GFP_KERNEL); =09if (!dvs_config->ycoords_y) =09=09goto err; =20 -=09dvs_config->xcoords_uv =3D kvmalloc(width_uv * height_uv * -=09=09=09=09=09 sizeof(uint32_t), +=09dvs_config->xcoords_uv =3D kvmalloc(array3_size(width_uv, height_uv, +=09=09=09=09=09=09 sizeof(uint32_t)), =09=09=09=09=09 GFP_KERNEL); =09if (!dvs_config->xcoords_uv) =09=09goto err; =20 -=09dvs_config->ycoords_uv =3D kvmalloc(width_uv * height_uv * -=09=09=09=09=09 sizeof(uint32_t), +=09dvs_config->ycoords_uv =3D kvmalloc(array3_size(width_uv, height_uv, +=09=09=09=09=09=09 sizeof(uint32_t)), =09=09=09=09=09 GFP_KERNEL); =09if (!dvs_config->ycoords_uv) =09=09goto err; --=20 2.43.0