From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B51442F56 for ; Mon, 22 Sep 2025 03:36:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758512204; cv=none; b=KuPJE/acwIilmzi9eXe4KW41/5+M85PgXeSc/gReDCyB7GVePKEM8hzm5RpEarKHQWmBzJWns/INchOTI/aOUUIyPKsXFAG6hJwMbu/VTJUv1CBis0RHxk+54sNM8hjl2zsnL3p3eewecn0WB84+2ykfenpgdKjglxHJlbjChs4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758512204; c=relaxed/simple; bh=rs/upMHA5jSOkvRjTN31EXKDVfPg7QxREApmEdYNWpU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iGolHZf/j22hdnlspW7o14X40jdRKInbVl6x2NLv9tTjjG0Ko6p3KsfXwwppVZVG3/0pclIRN6D2Qkne8NciegBYN1blIOiKquKO1Ef3tOg5tbTQnxfJyT8BEYAhqebU8NBdHwwOptqh8PhEv9L8kF1byzi46pjx5gLFZAWlJGM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=dYeIGHtX; arc=none smtp.client-ip=91.218.175.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="dYeIGHtX" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1758512191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9/pAYjt1PTM1WTwOEAJ1ryShiXtBMZp1571RlbpsQfQ=; b=dYeIGHtXEhwqRe5dY2kuaOhbMvjIC5LBJnI4MTLAavEHM28MO5fC1RBYYw1JQSenqd1Od+ ppNvqg9coKtIPXFQHgGtx3lExQK15m1zekX1RHO6FWDHA+ZXFNiB8BTagglJX3zuepxRoC P2383CbGkK919uOabMZSgfcRGK4vAQ8= Date: Mon, 22 Sep 2025 11:36:11 +0800 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH 1/1] mm/thp: fix MTE tag mismatch when replacing zero-filled subpages Content-Language: en-US To: Zi Yan Cc: akpm@linux-foundation.org, david@redhat.com, lorenzo.stoakes@oracle.com, usamaarif642@gmail.com, yuzhao@google.com, baolin.wang@linux.alibaba.com, baohua@kernel.org, voidice@gmail.com, Liam.Howlett@oracle.com, catalin.marinas@arm.com, cerasuolodomenico@gmail.com, hannes@cmpxchg.org, kaleshsingh@google.com, npache@redhat.com, riel@surriel.com, roman.gushchin@linux.dev, rppt@kernel.org, ryan.roberts@arm.com, dev.jain@arm.com, ryncsn@gmail.com, shakeel.butt@linux.dev, surenb@google.com, hughd@google.com, willy@infradead.org, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, ying.huang@linux.alibaba.com, apopple@nvidia.com, qun-wei.lin@mediatek.com, Andrew.Yang@mediatek.com, casper.li@mediatek.com, chinwen.chang@mediatek.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-mm@kvack.org, ioworker0@gmail.com, stable@vger.kernel.org, linux-riscv@lists.infradead.org, palmer@rivosinc.com, samuel.holland@sifive.com, charlie@rivosinc.com References: <20250922021458.68123-1-lance.yang@linux.dev> <3DD2EF5E-3E6A-40B0-AFCC-8FB38F0763DB@nvidia.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Lance Yang In-Reply-To: <3DD2EF5E-3E6A-40B0-AFCC-8FB38F0763DB@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Cc: RISC-V folks On 2025/9/22 10:36, Zi Yan wrote: > On 21 Sep 2025, at 22:14, Lance Yang wrote: > >> From: Lance Yang >> >> When both THP and MTE are enabled, splitting a THP and replacing its >> zero-filled subpages with the shared zeropage can cause MTE tag mismatch >> faults in userspace. >> >> Remapping zero-filled subpages to the shared zeropage is unsafe, as the >> zeropage has a fixed tag of zero, which may not match the tag expected by >> the userspace pointer. >> >> KSM already avoids this problem by using memcmp_pages(), which on arm64 >> intentionally reports MTE-tagged pages as non-identical to prevent unsafe >> merging. >> >> As suggested by David[1], this patch adopts the same pattern, replacing the >> memchr_inv() byte-level check with a call to pages_identical(). This >> leverages existing architecture-specific logic to determine if a page is >> truly identical to the shared zeropage. >> >> Having both the THP shrinker and KSM rely on pages_identical() makes the >> design more future-proof, IMO. Instead of handling quirks in generic code, >> we just let the architecture decide what makes two pages identical. >> >> [1] https://lore.kernel.org/all/ca2106a3-4bb2-4457-81af-301fd99fbef4@redhat.com >> >> Cc: >> Reported-by: Qun-wei Lin >> Closes: https://lore.kernel.org/all/a7944523fcc3634607691c35311a5d59d1a3f8d4.camel@mediatek.com >> Fixes: b1f202060afe ("mm: remap unused subpages to shared zeropage when splitting isolated thp") >> Suggested-by: David Hildenbrand >> Signed-off-by: Lance Yang >> --- >> Tested on x86_64 and on QEMU for arm64 (with and without MTE support), >> and the fix works as expected. > > From [1], I see you mentioned RISC-V also has the address masking feature. > Is it affected by this? And memcmp_pages() is only implemented by ARM64 > for MTE. Should any arch with address masking always implement it to avoid > the same issue? Yeah, I'm new to RISC-V, seems like RISC-V has a similar feature as described in Documentation/arch/riscv/uabi.rst, which is the Supm (Supervisor-mode Pointer Masking) extension. ``` Pointer masking --------------- Support for pointer masking in userspace (the Supm extension) is provided via the ``PR_SET_TAGGED_ADDR_CTRL`` and ``PR_GET_TAGGED_ADDR_CTRL`` ``prctl()`` operations. Pointer masking is disabled by default. To enable it, userspace must call ``PR_SET_TAGGED_ADDR_CTRL`` with the ``PR_PMLEN`` field set to the number of mask/tag bits needed by the application. ``PR_PMLEN`` is interpreted as a lower bound; if the kernel is unable to satisfy the request, the ``PR_SET_TAGGED_ADDR_CTRL`` operation will fail. The actual number of tag bits is returned in ``PR_PMLEN`` by the ``PR_GET_TAGGED_ADDR_CTRL`` operation. ``` But, IIUC, Supm by itself only ensures that the upper bits are ignored on memory access :) So, RISC-V today would likely not be affected. However, once it implements full hardware tag checking, it will face the exact same zero-page problem. Anyway, any architecture with a feature like MTE in the future will need its own memcmp_pages() to prevent unsafe merges ;) > >> >> mm/huge_memory.c | 15 +++------------ >> mm/migrate.c | 8 +------- >> 2 files changed, 4 insertions(+), 19 deletions(-) >> >> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >> index 32e0ec2dde36..28d4b02a1aa5 100644 >> --- a/mm/huge_memory.c >> +++ b/mm/huge_memory.c >> @@ -4104,29 +4104,20 @@ static unsigned long deferred_split_count(struct shrinker *shrink, >> static bool thp_underused(struct folio *folio) >> { >> int num_zero_pages = 0, num_filled_pages = 0; >> - void *kaddr; >> int i; >> >> for (i = 0; i < folio_nr_pages(folio); i++) { >> - kaddr = kmap_local_folio(folio, i * PAGE_SIZE); >> - if (!memchr_inv(kaddr, 0, PAGE_SIZE)) { >> - num_zero_pages++; >> - if (num_zero_pages > khugepaged_max_ptes_none) { >> - kunmap_local(kaddr); >> + if (pages_identical(folio_page(folio, i), ZERO_PAGE(0))) { >> + if (++num_zero_pages > khugepaged_max_ptes_none) >> return true; >> - } >> } else { >> /* >> * Another path for early exit once the number >> * of non-zero filled pages exceeds threshold. >> */ >> - num_filled_pages++; >> - if (num_filled_pages >= HPAGE_PMD_NR - khugepaged_max_ptes_none) { >> - kunmap_local(kaddr); >> + if (++num_filled_pages >= HPAGE_PMD_NR - khugepaged_max_ptes_none) >> return false; >> - } >> } >> - kunmap_local(kaddr); >> } >> return false; >> } >> diff --git a/mm/migrate.c b/mm/migrate.c >> index aee61a980374..ce83c2c3c287 100644 >> --- a/mm/migrate.c >> +++ b/mm/migrate.c >> @@ -300,9 +300,7 @@ static bool try_to_map_unused_to_zeropage(struct page_vma_mapped_walk *pvmw, >> unsigned long idx) >> { >> struct page *page = folio_page(folio, idx); >> - bool contains_data; >> pte_t newpte; >> - void *addr; >> >> if (PageCompound(page)) >> return false; >> @@ -319,11 +317,7 @@ static bool try_to_map_unused_to_zeropage(struct page_vma_mapped_walk *pvmw, >> * this subpage has been non present. If the subpage is only zero-filled >> * then map it to the shared zeropage. >> */ >> - addr = kmap_local_page(page); >> - contains_data = memchr_inv(addr, 0, PAGE_SIZE); >> - kunmap_local(addr); >> - >> - if (contains_data) >> + if (!pages_identical(page, ZERO_PAGE(0))) >> return false; >> >> newpte = pte_mkspecial(pfn_pte(my_zero_pfn(pvmw->address), >> -- >> 2.49.0 > > The changes look good to me. Thanks. Acked-by: Zi Yan Cheers!