From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f195.google.com ([209.85.214.195]:40884 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728149AbeIUUtC (ORCPT ); Fri, 21 Sep 2018 16:49:02 -0400 Subject: Re: [PATCH net] ixgbe: check return value of napi_complete_done() To: Alexei Starovoitov , Eric Dumazet , Song Liu Cc: Jeff Kirsher , netdev , "intel-wired-lan@lists.osuosl.org" , Kernel Team , "stable@vger.kernel.org" , Alexei Starovoitov References: <20180920190113.490005-1-songliubraving@fb.com> <2ca0e823642d232092017f66e8151652e22e74a1.camel@intel.com> <0DAF1AF9-E98D-4D0F-BD68-F5936A0312C6@fb.com> <028b4cea-0e3f-fab5-7a74-cf003bbd1134@gmail.com> <74672b30-1627-efcd-383f-adda6cdf486f@gmail.com> <71fd1305-17ad-2bdc-c123-9bc0ab37b0a4@fb.com> From: Eric Dumazet Message-ID: Date: Fri, 21 Sep 2018 07:59:45 -0700 MIME-Version: 1.0 In-Reply-To: <71fd1305-17ad-2bdc-c123-9bc0ab37b0a4@fb.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 09/21/2018 07:55 AM, Alexei Starovoitov wrote: > > should we remove ndo_poll_controller then? > My understanding that the patch helps by not letting > drivers do napi_schedule() for all queues into this_cpu, right? > But most of the drivers do exactly that in their ndo_poll_controller > implementations. Means most of the drivers will experience > this nasty behavior. > Some legacy drivers do not use NAPI yet, but provide ndo_poll_controller() I believe users caring about system behavior with multi queue NIC are all using NAPI enabled drivers, so this should be fine.