From: Jiri Slaby <jirislaby@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>,
Greg KH <gregkh@linuxfoundation.org>,
Sasha Levin <sashal@kernel.org>
Cc: stable <stable@vger.kernel.org>, Jian Cai <jiancai@google.com>,
Fangrui Song <maskray@google.com>,
Sami Tolvanen <samitolvanen@google.com>,
Borislav Petkov <bp@suse.de>,
Nathan Chancellor <natechancellor@gmail.com>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: 5.4 and 4.19 fix for LLVM_IAS/clang-12
Date: Wed, 9 Dec 2020 08:21:43 +0100 [thread overview]
Message-ID: <e9695da9-8b83-39a5-8781-47ae4c7d2e51@kernel.org> (raw)
In-Reply-To: <a3b89f95-2635-ff9d-4248-4e5e3065ff85@kernel.org>
On 09. 12. 20, 8:20, Jiri Slaby wrote:
> On 09. 12. 20, 1:12, Nick Desaulniers wrote:
>> Dear stable kernel maintainers,
>> Please consider accepting the following backport to 5.4 and 4.19 of
>> commit 4d6ffa27b8e5 ("x86/lib: Change .weak to SYM_FUNC_START_WEAK for
>> arch/x86/lib/mem*_64.S"), attached.
>>
>> The patch to 5.4 had a conflict due to 5.4 missing upstream commit
>> e9b9d020c487 ("x86/asm: Annotate aliases") which first landed in
>> v5.5-rc1.
>>
>> The patch to 4.19 had a conflict due to 4.19 missing the above commit
>> and ffedeeb780dc ("linkage: Introduce new macros for assembler
>> symbols") which also first landed in v5.5-rc1 but was backported to
>> linux-5.4.y as commit 840d8c9b3e5f ("linkage: Introduce new macros for
>> assembler symbols") which shipped in v5.4.76.
>>
>> This patch fixes a build error from clang's assembler when building
>> with Clang-12, which now errors when symbols are redeclared with
>> different bindings. We're using clang's assembler in Android and
>> ChromeOS for 4.19+.
>>
>> Jiri, would you mind reviewing the 4.19 patch (or both)? It simply
>> open codes what the upstream macros would expand to; this can be and
>> was observed from running:
>
> You don't have to touch (expand) __memcpy, __memmove, and __memset, right?
Also, no need for doubled p2align.
> thanks,
--
js
next prev parent reply other threads:[~2020-12-09 7:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 0:12 5.4 and 4.19 fix for LLVM_IAS/clang-12 Nick Desaulniers
2020-12-09 7:20 ` Jiri Slaby
2020-12-09 7:21 ` Jiri Slaby [this message]
2020-12-10 21:15 ` Nick Desaulniers
2020-12-11 14:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9695da9-8b83-39a5-8781-47ae4c7d2e51@kernel.org \
--to=jirislaby@kernel.org \
--cc=bp@suse.de \
--cc=clang-built-linux@googlegroups.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiancai@google.com \
--cc=maskray@google.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=samitolvanen@google.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).