Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: Neal Cardwell <ncardwell@google.com>
Cc: Wei Wang <weiwan@google.com>, David Miller <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, Soheil Hassas Yeganeh <soheil@google.com>,
	Yuchung Cheng <ycheng@google.com>, LemmyHuang <hlm3280@163.com>,
	stable <stable@vger.kernel.org>,
	"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
	temotor@gmail.com, jakub@stasiak.at
Subject: Re: python-eventlet test broken in 5.19 [was: Revert "tcp: change pingpong threshold to 3"]
Date: Wed, 17 Aug 2022 08:44:27 +0200	[thread overview]
Message-ID: <eca0e388-bdd1-7d83-76a8-971de8e3a0ce@kernel.org> (raw)
In-Reply-To: <CADVnQy=AnJY9NZ3w_xNghEG80-DhsXL0r_vEtkr=dmz0ugcoVw@mail.gmail.com>

On 17. 08. 22, 0:19, Neal Cardwell wrote:
> IMHO the best solution here is to tweak the test code so that it does
> not race and depend on the exact timing of TCP ACKs. One possible way
> to achieve this would be to have the client TCP connection use
> setsockopt(TCP_NODELAY) so that the body for the PUT /2 request is
> transmitted immediately, whether or not the server delays the ACK of
> the PUT /2 headers.

Thanks a lot, Neal! So for the time being, until this is resolved in 
eventlet, I pushed a change to disable the test in openSUSE.

thanks,
-- 
js


  reply	other threads:[~2022-08-17  6:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220721204404.388396-1-weiwan@google.com>
2022-08-06 10:02 ` [PATCH net v2] Revert "tcp: change pingpong threshold to 3" Jiri Slaby
2022-08-06 11:24   ` Neal Cardwell
2022-08-06 14:41     ` Jiri Slaby
2022-08-15  7:48       ` Jiri Slaby
2022-08-15 13:30         ` Neal Cardwell
2022-08-15 18:54           ` Wei Wang
2022-08-15 19:19             ` Neal Cardwell
2022-08-16  5:48           ` python-eventlet test broken in 5.19 [was: Revert "tcp: change pingpong threshold to 3"] Jiri Slaby
2022-08-16 22:19             ` Neal Cardwell
2022-08-17  6:44               ` Jiri Slaby [this message]
2022-08-18 17:50                 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eca0e388-bdd1-7d83-76a8-971de8e3a0ce@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hlm3280@163.com \
    --cc=jakub@stasiak.at \
    --cc=kuba@kernel.org \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=soheil@google.com \
    --cc=stable@vger.kernel.org \
    --cc=temotor@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=weiwan@google.com \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox