From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 22764228C91; Wed, 5 Feb 2025 07:24:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738740247; cv=none; b=XRv7VM9+umepuvrYNCVO3oZND9rRRzVIb+OUfY8D0Ac36Z+BhyPNI8emo7BR9RAjA3UfOOd/9erRqsFcEPQYv6wRkCH7QDed45DAv+/AmXpnh0cvPtvyBLi+z6gkXC160rHG+4SCYCg7E2fbDbRNjM0q3ufmRuCJX/QWwgkV1BM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738740247; c=relaxed/simple; bh=Cj+Pbd2/n1KYGHKtDmEbSbjEAdbJy4st9tAoUhSsWuU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iEYbVG6iquzznsi8XTDZLSBDUUvNSALXxDJzPJjPBA1HfmUyz/RYmQhqQ3tzG+Yo+WD67iufta3O9qTa9MmL1Gb2KX/q4PDcejNTBDYpBX3g1Hegf+Al8MZ5NWVbI7ZJXEfimMwFPH+U/4yBJ60qj9DVEaTnduxmTStjeTFOK8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=JRD5kY+C; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="JRD5kY+C" Received: from [10.95.84.73] (unknown [167.220.238.9]) by linux.microsoft.com (Postfix) with ESMTPSA id 89ABC203F585; Tue, 4 Feb 2025 23:24:01 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 89ABC203F585 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1738740245; bh=M5OQQ11HeiOo2qp+8sLAhdiGvT4ZXKIkzKf7G8IAmO4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JRD5kY+C9R5ef8/QcMU5axu1dttEyYFB/4dQvNdFAOgiM/L+aKx4soAdj7ug4jrVd SJmWcMthL9Aw19RU7G6WcITKUyIuRs4zIL5+DrGi1L1Y0FTTQwZj+FapQaPm8rgofz BlPuJY7Rl6YlayUXg+vWkeiGrdpqspU1Vr1c1tus= Message-ID: Date: Wed, 5 Feb 2025 12:53:58 +0530 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] sched/topology: Enable topology_span_sane check only for debug builds To: K Prateek Nayak , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, Steve Wahl , Saurabh Singh Sengar , srivatsa@csail.mit.edu, Michael Kelley References: <20250203114738.3109-1-namjain@linux.microsoft.com> Content-Language: en-US From: Naman Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/5/2025 12:50 PM, K Prateek Nayak wrote: > Hello Naman, > > On 2/3/2025 5:17 PM, Naman Jain wrote: >> From: Saurabh Sengar >> >> On a x86 system under test with 1780 CPUs, topology_span_sane() takes <.> >>   { >>       int i = cpu + 1; >> +    /* Skip the topology sanity check for non-debug, as it is a time- >> consuming operatin */ > > s/operatin/operation/ > >> +    if (!sched_debug()) { >> +        pr_info_once("%s: Skipping topology span sanity check. Use >> `sched_verbose` boot parameter to enable it.\n", > > This could be broken down as follows: > >         pr_info_once("%s: Skipping topology span sanity check." >                  " Use `sched_verbose` boot parameter to enable it.\n", >                  __func__); > > Running: > >     grep -r -A 5 "pr_info(.*[^;,]$" kernel/ > > gives similar usage across kernel/*. Apart from those nits, feel > free to add: > > Tested-by: K Prateek Nayak # x86 > > if the future version does not change much. > Hello Prateek, Thanks for reviewing and testing this. I'll make changes based on your feedback in next version. Regards, Naman