Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
	linux-samsung-soc@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Peter Griffin <peter.griffin@linaro.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: samsung: exynos4210-universal_c210: fix BCM4330 Bluetooth GPIOs
Date: Mon, 2 Nov 2026 13:26:58 +0100	[thread overview]
Message-ID: <eeca871d-ca1f-4cd4-b40a-570f0805dbd1@kernel.org> (raw)
In-Reply-To: <20261026103607.968295-1-m.szyprowski@samsung.com>

On 26/10/2026 11:36, Marek Szyprowski wrote:
> BT_REG_ON (BT_EN) line of the BCM4330 WLAN/BT combo chip is connected to
> the XMMC1CMD pad (GPK1[1]), while the XMDMADDR_4 pad (GPE1[4]) is
> connected to BT_RST (BT_nRST). The Bluetooth node however used GPE1[4]
> as shutdown-gpios and left the real BT_REG_ON line undriven, so it was
> kept low by the default SoC pull-down.
> 
> This worked only by accident: the internal regulators of the BCM4330 are
> enabled when either WL_REG_ON or BT_REG_ON is high, so the Bluetooth core
> was powered via WL_REG_ON driven by the SDIO WLAN power sequence, while
> toggling GPE1[4] only released it from reset. Once 'cap-power-off-card'
> was added to the SDIO node, the MMC core started to power off the WLAN
> part (asserting WL_REG_ON low) whenever it was idle, what cut off the
> Bluetooth power as well and resulted in HCI command timeouts.
> 
> Fix this by using GPK1[1] as shutdown-gpios and describing GPE1[4] as
> active-low reset-gpios. While touching this, move the GPE1[4] pin
> configuration to the pinctrl_0 node, as GPE1 bank belongs to that pin
> controller, what fixes the following error:
> 
>   samsung-pinctrl 11000000.pinctrl: does not have pin group gpe1-4
> 
> Fixes: 8929d4a9d204 ("ARM: dts: exynos: Enable BlueTooth support for Universal C210 board")

Unknown SHA.

Best regards,
Krzysztof

  reply	other threads:[~2026-11-02 12:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20261026103612eucas1p10fbe3777394cc604419299509c22a2e7@eucas1p1.samsung.com>
2026-10-26 10:36 ` [PATCH] ARM: dts: samsung: exynos4210-universal_c210: fix BCM4330 Bluetooth GPIOs Marek Szyprowski
2026-11-02 12:26   ` Krzysztof Kozlowski [this message]
2026-11-02 12:43     ` Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eeca871d-ca1f-4cd4-b40a-570f0805dbd1@kernel.org \
    --to=krzk@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=peter.griffin@linaro.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox