Re: [REGRESSION] applespi from 6.12 onwards

[kobarity <kobarity@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]


Hi

I'm also experiencing this problem on my MacBookPro14,3.

Aditya Garg wrote:
> 
> Hi Jörg
> 
> Can you test the kernel here to see if this fixes your issue:
> 
> https://github.com/t2linux/T2-Debian-and-Ubuntu-Kernel/actions/runs/14944200356
> 
> Alternatively you can try compiling your own kernel with this patch:
> 
> https://lore.kernel.org/all/0-v1-c26553717e90+65f-iommu_vtd_ss_wo_jgg@nvidia.com/

As far as I have tried, this patch did not solve the problem.

By bisecting, I found that this problem was introduced by commit
2031c469f816 ("iommu/vt-d: Add support for static identity domain").
In fact, since this commit, it will panic at startup.  This panic was
fixed by commit 6e02a277f1db ("iommu/vt-d: Fix incorrect
pci_for_each_dma_alias() for non-PCI devices").  So I applied commit
6e02a277f1db on commit 2031c469f816 and confirmed that the keyboard
and touchpad is not working.

I also found that I can workaround this problem by reverting only the
intel_iommu_attach_device() change in commit 2031c469f816 as in the
attached patch, but I'm not sure if this is a reasonable fix.


[-- Attachment #2: workaround.patch --]
[-- Type: application/octet-stream, Size: 601 bytes --]

diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index cb0b993bebb4..14da33490fa1 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -3484,9 +3484,11 @@ int paging_domain_compatible(struct iommu_domain *domain, struct device *dev)
 static int intel_iommu_attach_device(struct iommu_domain *domain,
 				     struct device *dev)
 {
+	struct device_domain_info *info = dev_iommu_priv_get(dev);
 	int ret;
 
-	device_block_translation(dev);
+	if (info->domain)
+		device_block_translation(dev);
 
 	ret = paging_domain_compatible(domain, dev);
 	if (ret)