From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org, stable@vger.kernel.org,
Mariusz Dabrowski <mariusz.dabrowski@intel.com>,
Ming Lin <ming.l@ssi.samsung.com>,
Mike Snitzer <snitzer@redhat.com>, Christoph Hellwig <hch@lst.de>,
Xiao Ni <xni@redhat.com>
Subject: Re: [PATCH] block: don't deal with discard limit in blkdev_issue_discard()
Date: Thu, 18 Oct 2018 07:23:56 -0600 [thread overview]
Message-ID: <f025344a-3ecf-afe0-4bcf-439d0b3051cf@kernel.dk> (raw)
In-Reply-To: <20181012075310.4587-1-ming.lei@redhat.com>
On 10/12/18 1:53 AM, Ming Lei wrote:
> blk_queue_split() does respect this limit via bio splitting, so no
> need to do that in blkdev_issue_discard(), then we can align to
> normal bio submit(bio_add_page() & submit_bio()).
>
> More importantly, this patch fixes one issue introduced in a22c4d7e34402cc
> ("block: re-add discard_granularity and alignment checks"), in which
> zero discard bio may be generated in case of zero alignment.
Thanks Ming, applied.
--
Jens Axboe
prev parent reply other threads:[~2018-10-18 21:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 7:53 [PATCH] block: don't deal with discard limit in blkdev_issue_discard() Ming Lei
2018-10-17 7:06 ` Dabrowski, Mariusz
2018-10-18 0:12 ` Ming Lei
2018-10-18 13:23 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f025344a-3ecf-afe0-4bcf-439d0b3051cf@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=mariusz.dabrowski@intel.com \
--cc=ming.l@ssi.samsung.com \
--cc=ming.lei@redhat.com \
--cc=snitzer@redhat.com \
--cc=stable@vger.kernel.org \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox