From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail-it1-f194.google.com ([209.85.166.194]:40036 "EHLO
        mail-it1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727387AbeJRVZC (ORCPT
        <rfc822;stable@vger.kernel.org>); Thu, 18 Oct 2018 17:25:02 -0400
Received: by mail-it1-f194.google.com with SMTP id i191-v6so279428iti.5
        for <stable@vger.kernel.org>; Thu, 18 Oct 2018 06:24:00 -0700 (PDT)
Subject: Re: [PATCH] block: don't deal with discard limit in
 blkdev_issue_discard()
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org, stable@vger.kernel.org,
        Mariusz Dabrowski <mariusz.dabrowski@intel.com>,
        Ming Lin <ming.l@ssi.samsung.com>,
        Mike Snitzer <snitzer@redhat.com>,
        Christoph Hellwig <hch@lst.de>, Xiao Ni <xni@redhat.com>
References: <20181012075310.4587-1-ming.lei@redhat.com>
From: Jens Axboe <axboe@kernel.dk>
Message-ID: <f025344a-3ecf-afe0-4bcf-439d0b3051cf@kernel.dk>
Date: Thu, 18 Oct 2018 07:23:56 -0600
MIME-Version: 1.0
In-Reply-To: <20181012075310.4587-1-ming.lei@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On 10/12/18 1:53 AM, Ming Lei wrote:
> blk_queue_split() does respect this limit via bio splitting, so no
> need to do that in blkdev_issue_discard(), then we can align to
> normal bio submit(bio_add_page() & submit_bio()).
> 
> More importantly, this patch fixes one issue introduced in a22c4d7e34402cc
> ("block: re-add discard_granularity and alignment checks"), in which
> zero discard bio may be generated in case of zero alignment.

Thanks Ming, applied.

-- 
Jens Axboe