Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Lizhi Hou <lizhi.hou@amd.com>
To: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>,
	<dri-devel@lists.freedesktop.org>
Cc: <jeff.hugo@oss.qualcomm.com>, <stable@vger.kernel.org>
Subject: Re: [PATCH] accel/ivpu: Fix warning in ivpu_gem_bo_free()
Date: Wed, 28 May 2025 09:33:56 -0700	[thread overview]
Message-ID: <f2cc768c-3daa-3219-a0e4-703cee8abd78@amd.com> (raw)
In-Reply-To: <20250528154225.500394-1-jacek.lawrynowicz@linux.intel.com>


On 5/28/25 08:42, Jacek Lawrynowicz wrote:
> Don't WARN if imported buffers are in use in ivpu_gem_bo_free() as they
> can be indeed used in the original context/driver.
>
> Fixes: 647371a6609d ("accel/ivpu: Add GEM buffer object management")
> Cc: <stable@vger.kernel.org> # v6.3
> Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
> ---
>   drivers/accel/ivpu/ivpu_gem.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c
> index 5908268ca45e9..0371a8b4a474f 100644
> --- a/drivers/accel/ivpu/ivpu_gem.c
> +++ b/drivers/accel/ivpu/ivpu_gem.c
> @@ -285,7 +285,8 @@ static void ivpu_gem_bo_free(struct drm_gem_object *obj)
>   	list_del(&bo->bo_list_node);
>   	mutex_unlock(&vdev->bo_list_lock);
>   
> -	drm_WARN_ON(&vdev->drm, !dma_resv_test_signaled(obj->resv, DMA_RESV_USAGE_READ));
> +	drm_WARN_ON(&vdev->drm, !bo->base.base.import_attach &&
> +		    !dma_resv_test_signaled(obj->resv, DMA_RESV_USAGE_READ));

Probably drm_gem_is_imported()?

Thanks,

Lizhi

>   	drm_WARN_ON(&vdev->drm, ivpu_bo_size(bo) == 0);
>   	drm_WARN_ON(&vdev->drm, bo->base.vaddr);
>   

  reply	other threads:[~2025-05-28 16:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-28 15:42 [PATCH] accel/ivpu: Fix warning in ivpu_gem_bo_free() Jacek Lawrynowicz
2025-05-28 16:33 ` Lizhi Hou [this message]
2025-05-28 17:04   ` Jacek Lawrynowicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2cc768c-3daa-3219-a0e4-703cee8abd78@amd.com \
    --to=lizhi.hou@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jacek.lawrynowicz@linux.intel.com \
    --cc=jeff.hugo@oss.qualcomm.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox