Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: wangzijie <wangzijie1@honor.com>,
	akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
	adobriyan@gmail.com, rick.p.edgecombe@intel.com, ast@kernel.org,
	kirill.shutemov@linux.intel.com
Cc: polynomial-c@gmx.de, gregkh@linuxfoundation.org,
	stable@vger.kernel.org, regressions@lists.linux.dev
Subject: Re: [PATCH] proc: fix wrong behavior of FMODE_LSEEK clearing for net related proc file
Date: Mon, 18 Aug 2025 07:01:56 +0200	[thread overview]
Message-ID: <f2ff00e6-a931-4c61-a43d-fb3e450f7ffd@kernel.org> (raw)
In-Reply-To: <20250818040535.564611-1-wangzijie1@honor.com>

Hi,

On 18. 08. 25, 6:05, wangzijie wrote:
> For avoiding pde->proc_ops->... dereference(which may cause UAF in rmmod race scene),
> we call pde_set_flags() to save this kind of information in PDE itself before
> proc_register() and call pde_has_proc_XXX() to replace pde->proc_ops->... dereference.
> But there has omission of pde_set_flags() in net related proc file create, which cause
> the wroing behavior of FMODE_LSEEK clearing in proc_reg_open() for net related proc file
> after commit ff7ec8dc1b64("proc: use the same treatment to check proc_lseek as ones for
> proc_read_iter et.al"). Lars reported it in this link[1]. So call pde_set_flags() when
> create net related proc file to fix this bug.

I wonder, why is pde_set_flags() not a part of proc_register()?

Could you also use some LLM to reformat the message into something 
comprehensible?

thanks,
-- 
js
suse labs


  reply	other threads:[~2025-08-18  5:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18  4:05 [PATCH] proc: fix wrong behavior of FMODE_LSEEK clearing for net related proc file wangzijie
2025-08-18  5:01 ` Jiri Slaby [this message]
2025-08-18  8:01   ` wangzijie
2025-08-18  8:08     ` Jiri Slaby
2025-08-18  8:11       ` Jiri Slaby
2025-08-18  8:29         ` wangzijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2ff00e6-a931-4c61-a43d-fb3e450f7ffd@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=ast@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=polynomial-c@gmx.de \
    --cc=regressions@lists.linux.dev \
    --cc=rick.p.edgecombe@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=wangzijie1@honor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox