From: Florian Fainelli <f.fainelli@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>, Al Cooper <alcooperx@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
bcm-kernel-feedback-list@broadcom.com,
Nicolas Schichan <nschichan@freebox.fr>
Cc: Arnd Bergmann <arnd@arndb.de>,
stable@vger.kernel.org, Douglas Anderson <dianders@chromium.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: brcmstb: Fix sdhci_pltfm_suspend link error
Date: Mon, 25 Jan 2021 09:40:16 -0800 [thread overview]
Message-ID: <f671f5d2-36c4-ded5-c4b9-93c5c57cc9f2@gmail.com> (raw)
In-Reply-To: <20210125125050.102605-1-arnd@kernel.org>
+Nicolas,
On 1/25/2021 4:50 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> sdhci_pltfm_suspend() is only available when CONFIG_PM_SLEEP
> support is built into the kernel, which caused a regression
> in a recent bugfix:
>
> ld.lld: error: undefined symbol: sdhci_pltfm_suspend
>>>> referenced by sdhci-brcmstb.c
>>>> mmc/host/sdhci-brcmstb.o:(sdhci_brcmstb_shutdown) in archive drivers/built-in.a
>
> Making the call conditional on the symbol fixes the link
> error.
>
> Fixes: 5b191dcba719 ("mmc: sdhci-brcmstb: Fix mmc timeout errors on S5 suspend")
> Fixes: e7b5d63a82fe ("mmc: sdhci-brcmstb: Add shutdown callback")
> Cc: stable@vger.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> It would be helpful if someone could test this to ensure that the
> driver works correctly even when CONFIG_PM_SLEEP is disabled
Why not create stubs for sdhci_pltfm_suspend() when CONFIG_PM_SLEEP=n? I
don't think this is going to be a functional issue given that the
purpose of having the .shutdown() function is to save power if we cannot
that is fine, too.
--
Florian
next prev parent reply other threads:[~2021-01-25 17:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 12:50 [PATCH] mmc: brcmstb: Fix sdhci_pltfm_suspend link error Arnd Bergmann
2021-01-25 17:40 ` Florian Fainelli [this message]
2021-01-26 9:55 ` Ulf Hansson
2021-01-26 16:41 ` Alan Cooper
2021-01-25 18:39 ` Nicolas Schichan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f671f5d2-36c4-ded5-c4b9-93c5c57cc9f2@gmail.com \
--to=f.fainelli@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=alcooperx@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dianders@chromium.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nschichan@freebox.fr \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox