From: Ping-Ke Shih <pkshih@realtek.com>
To: Vasily Khoruzhick <anarsoul@gmail.com>,
Kalle Valo <kvalo@kernel.org>, Fiona Klute <fiona.klute@gmx.de>,
Bitterblue Smith <rtl8821cerfe2@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] wifi: rtw88: 8703b: Fix RX/TX issues
Date: Fri, 3 Jan 2025 09:12:59 +0000 [thread overview]
Message-ID: <f69874f3c11f4c7b8b0e3026796bb452@realtek.com> (raw)
In-Reply-To: <20250103075107.1337533-1-anarsoul@gmail.com>
Vasily Khoruzhick <anarsoul@gmail.com> wrote:
> Fix 3 typos in 8703b driver. 2 typos in calibration routines are not
> fatal and do not seem to have any impact, just fix them to match vendor
> driver.
Just curious how you can find these typos?
>
> However the last one in rtw8703b_set_channel_bb() clears too many bits
> in REG_OFDM0_TX_PSD_NOISE, causing TX and RX issues (neither rate goes
> above MCS0-MCS1). Vendor driver clears only 2 most significant bits.
>
> With the last typo fixed, the driver is able to reach MCS7 on Pinebook
>
> Cc: stable@vger.kernel.org
> Fixes: 9bb762b3a957 ("wifi: rtw88: Add definitions for 8703b chip")
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Is this urgent? If not, I will take this via rtw-next tree.
next prev parent reply other threads:[~2025-01-03 9:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 7:50 [PATCH] wifi: rtw88: 8703b: Fix RX/TX issues Vasily Khoruzhick
2025-01-03 9:12 ` Ping-Ke Shih [this message]
2025-01-03 11:55 ` Fiona Klute
2025-01-03 19:12 ` Vasily Khoruzhick
2025-01-03 17:30 ` Vasily Khoruzhick
2025-01-06 0:31 ` Ping-Ke Shih
2025-01-03 19:02 ` Andrey Skvortsov
2025-01-03 19:10 ` Vasily Khoruzhick
2025-01-03 20:19 ` Andrey Skvortsov
2025-01-03 20:53 ` Vasily Khoruzhick
2025-01-03 22:57 ` Andrey Skvortsov
2025-01-12 2:02 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f69874f3c11f4c7b8b0e3026796bb452@realtek.com \
--to=pkshih@realtek.com \
--cc=anarsoul@gmail.com \
--cc=fiona.klute@gmx.de \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox