From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Hui Wang <hui.wang@canonical.com>,
alsa-devel@alsa-project.org, stable@vger.kernel.org
Subject: Re: [PATCH] Revert "ALSA: hda: call runtime_allow() for all hda controllers"
Date: Mon, 3 Aug 2020 12:50:50 -0500 [thread overview]
Message-ID: <f6a66bc4-9f1a-0425-6f00-4ddce3a2b6cc@linux.intel.com> (raw)
In-Reply-To: <s5hk0yf39wj.wl-tiwai@suse.de>
>>>> Do I get this right that this permanently disables pm_runtime on all
>>>> Intel HDaudio controllers?
>>>
>>> It just drops the unconditional enablement of runtime PM.
>>> It can be enabled via sysfs, and that's the old default (let admin
>>> enabling it via udev or whatever).
>>
>> Sorry I am confused now.
>> Kai seemed to suggest in the Bugzilla comments that this would be
>> temporary, until these problems with i915 and ALC662 get fixed?
>
> Right, that's the plan. This patch revert to the old state before the
> forced-all-enable call we've taken in 5.7. On 5.7 and onwards, all
> HD-audio controllers are enforced to use the runtime PM. Before that
> version, the runtime PM was enabled *as default* only for limited
> devices (typically the ones bound with GPU); for other devices, the
> runtime PM is manually enabled from user-space via sysfs (and many
> distros enable them in anyway).
>
> The forced enablement was merged with a hope that now all HD-audio
> controllers behave nicely, but it turned out to cause a regression, so
> it was reverted. Once when we find out the real cause, we can flip
> the flag again.
ok, sounds good. I was concerned mainly because on the SOF driver side
we enable pm_runtime by default, so that's a difference in configuration
we need to be aware of when dealing with 'my speaker is silent' support
questions.
next prev parent reply other threads:[~2020-08-03 17:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 6:46 [PATCH] Revert "ALSA: hda: call runtime_allow() for all hda controllers" Hui Wang
2020-08-03 7:30 ` Takashi Iwai
2020-08-03 15:27 ` Pierre-Louis Bossart
2020-08-03 16:36 ` Takashi Iwai
2020-08-03 17:00 ` Pierre-Louis Bossart
2020-08-03 17:40 ` Takashi Iwai
2020-08-03 17:50 ` Pierre-Louis Bossart [this message]
2020-08-04 0:21 ` Hui Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6a66bc4-9f1a-0425-6f00-4ddce3a2b6cc@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=hui.wang@canonical.com \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox