Re: [regression] x86/amd_nb in 6.9.6/6.6.35/6.1.95

[Mario Limonciello <mario.limonciello@amd.com>]

On 6/21/2024 16:56, Yazen Ghannam wrote:
> On Fri, Jun 21, 2024 at 11:29:11PM +0200, Andreas Radke wrote:
>> Am Fri, 21 Jun 2024 14:59:20 +0200
>> schrieb Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
>>
>>> I'm announcing the release of the 6.9.6 kernel.
>>>
>>> All users of the 6.9 kernel series must upgrade.
>>>
>>> The updated 6.9.y git tree can be found at:
>>> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
>>> linux-6.9.y and can be browsed at the normal kernel.org git web
>>> browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary
>>>
>>> thanks,
>>>
>>> greg k-h
>>
>> Subject: x86/amd_nb: Check for invalid SMN reads
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/patch/?id=348008f0043cd5ba915cfde44027c59bdb8a6791
>>
>> This commit is breaking lid close system suspend
>> and opening won't bring the laptop back and no input is possible anymore
>> here. I have to hard reboot the laptop. It's a Lenovo Thinkpad T14 Gen1.
>> There's nothing in the journal.
>>
>> Reverting this commit on top of 6.6.35 allows proper suspend/resume
>> again.
>>
> 
> Thanks Andy for the report.
> 
> Mario,
> Any ideas? Maybe something with the platform drivers?
> 
> Thanks,
> Yazen

Interesting; I've tested this patch in my own tree for a few weeks now 
and never hit this.

Can you please share a dmesg log from bootup?  Is there an "error 
reading" message from amd-pmc?

Separately can you please add a debug statement to amd-pmc around the 
two calls for:
	err = amd_smn_read(0, AMD_PMC_BASE_ADDR_LO, &val);
	err = amd_smn_read(0, AMD_PMC_BASE_ADDR_HI, &val);

Both with and without the patch?  I'm guessing one of them is (~0ULL) 
which is exactly what this patch is actually looking for now.