From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH] net: ethoc: enable NAPI before poll may be scheduled To: Max Filippov , netdev@vger.kernel.org Cc: "David S. Miller" , Thierry Reding , Tobias Klauser , stable@vger.kernel.org References: <1496712676-11862-1-git-send-email-jcmvbkbc@gmail.com> From: Florian Fainelli Message-ID: Date: Tue, 6 Jun 2017 07:26:20 -0700 MIME-Version: 1.0 In-Reply-To: <1496712676-11862-1-git-send-email-jcmvbkbc@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 06/05/2017 06:31 PM, Max Filippov wrote: > ethoc_reset enables device interrupts, ethoc_interrupt may schedule a > NAPI poll before NAPI is enabled in the ethoc_open, which results in > device being unable to send or receive anything until it's closed and > reopened. In case the device is flooded with ingress packets it may be > unable to recover at all. > Move napi_enable above ethoc_reset in the ethoc_open to fix that. > > Cc: stable@vger.kernel.org > Signed-off-by: Max Filippov Fixes: a1702857724f ("net: Add support for the OpenCores 10/100 Mbps Ethernet MAC.") Reviewed-by: Florian Fainelli -- Florian