From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Ben Hutchings To: linux-kernel@vger.kernel.org, stable@vger.kernel.org CC: akpm@linux-foundation.org, "Wei Liu" , "Ian Campbell" , "David S. Miller" Date: Sun, 16 Jun 2013 23:01:37 +0100 Message-ID: Subject: [16/83] netback: remove redundant assignment In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: 3.2.47-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Wei Liu commit 16ecba2605a3bbd374cd993e532264e2d8de49e5 upstream. New value for netbk->mmap_pages[pending_idx] is assigned in xen_netbk_alloc_page(), no need for a second assignment which exposes internal to the outside world. Signed-off-by: Wei Liu Acked-by: Ian Campbell Signed-off-by: David S. Miller Signed-off-by: Ben Hutchings --- drivers/net/xen-netback/netback.c | 4 ---- 1 file changed, 4 deletions(-) --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -951,8 +951,6 @@ static struct gnttab_copy *xen_netbk_get if (!page) goto err; - netbk->mmap_pages[pending_idx] = page; - gop->source.u.ref = txp->gref; gop->source.domid = vif->domid; gop->source.offset = txp->offset; @@ -1361,8 +1359,6 @@ static unsigned xen_netbk_tx_build_gops( continue; } - netbk->mmap_pages[pending_idx] = page; - gop->source.u.ref = txreq.gref; gop->source.domid = vif->domid; gop->source.offset = txreq.offset;