From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Ben Hutchings To: linux-kernel@vger.kernel.org, stable@vger.kernel.org CC: akpm@linux-foundation.org, "David S. Miller" , "Alexei Starovoitov" , "Li RongQing" Date: Sat, 07 Jun 2014 02:26:28 +0100 Message-ID: Subject: [PATCH 3.2 24/92] ipv4: initialise the itag variable in __mkroute_input In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: 3.2.60-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Li RongQing [ Upstream commit fbdc0ad095c0a299e9abf5d8ac8f58374951149a ] the value of itag is a random value from stack, and may not be initiated by fib_validate_source, which called fib_combine_itag if CONFIG_IP_ROUTE_CLASSID is not set This will make the cached dst uncertainty Signed-off-by: Li RongQing Acked-by: Alexei Starovoitov Signed-off-by: David S. Miller Signed-off-by: Ben Hutchings --- net/ipv4/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 6768ce2..6526110 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -2142,7 +2142,7 @@ static int __mkroute_input(struct sk_buff *skb, struct in_device *out_dev; unsigned int flags = 0; __be32 spec_dst; - u32 itag; + u32 itag = 0; /* get a working reference to the output device */ out_dev = __in_dev_get_rcu(FIB_RES_DEV(*res));