Re: [PATCH 3.2 31/46] IB/security: Restrict use of the write() interface

Ben Hutchings
2016-06-14T21:23:35Z

[-- Attachment #1: Type: text/plain, Size: 1539 bytes --]

On Tue, 2016-06-14 at 22:11 +0100, Sudip Mukherjee wrote:
> On Sunday 12 June 2016 10:34 PM, Ben Hutchings wrote:
> > 3.2.81-rc1 review patch.  If anyone has any objections, please let
> > me know.
> >
> > ------------------
> >
> > From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> >
> > commit e6bd18f57aad1a2d1ef40e646d03ed0f2515c9e3 upstream.
> >
> > The drivers/infiniband stack uses write() as a replacement for
> > bi-directional ioctl().  This is not safe. There are ways to
> > trigger write calls that result in the return structure that
> > is normally written to user space being shunted off to user
> > specified kernel memory instead.
> >
>
> <snip>
>
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > ---
> > --- a/drivers/infiniband/core/ucm.c
> > +++ b/drivers/infiniband/core/ucm.c
> > @@ -48,6 +48,7 @@
> >
> >   #include <asm/uaccess.h>
> >
> > +#include <rdma/ib.h>
>
> This is breaking the build. There is no rdma/ib.h .

This backported patch adds it.

> The file was created by:
> 8d36eb01da5d ("RDMA/cma: Define native IB address")
>
> build log is at: https://gitlab.com/sudipm/linux-next/builds/1771265

It looks like your patch queue tester doesn't account for patches that
create new files.

Ben.

--
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
- Albert
Camus

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]