Re: [PATCH 3.16 310/366] vmxnet3: fix checks for dma mapping errors

Thomas Weißschuh
2019-04-01T10:27:52Z

Hi Ben,

thanks for the prompt reply.

On Fri, Mar 29, 2019 at 11:55:34PM +0000, Ben Hutchings wrote:
> On Fri, 2019-03-29 at 17:01 +0100, Thomas Weißschuh wrote:
> > Hi Ben,
> >
> > I forgot you to Cc: on the following mail:
> >
> > https://lore.kernel.org/stable/20190329154756.GA14540@fralrnd0033.fra.amadeus.net/
> >
> > Thomas
> >
> > On Fri, Mar 29, 2019 at 04:47:58PM +0100, Thomas Weißschuh wrote:
> > > > 3.16.60-rc1 review patch. If anyone has any objections, please let me know.
> > >
> > > Sorry for the late response, this just hit the kernel in Debian Jessie
> > > (oldstable) a few days ago.
> > >
> > > > ------------------
> > > >
> > > > From: Alexey Khoroshilov <khoroshilov@ispras.ru>
> > > >
> > > > commit 5738a09d58d5ad2871f1f9a42bf6a3aa9ece5b3c upstream.
> > > >
> > > > vmxnet3_drv does not check dma_addr with dma_mapping_error()
> > > > after mapping dma memory. The patch adds the checks and
> > > > tries to handle failures.
> > >
> > > We are seeing kernel panics/machine freezes/BUGs with the new 3.16.64 from Debian.
> > > I bisected it with the vanilla stable kernel and it boiled down to this commit.
> > > VMs of multiple nodes of our vmware cluster are affected.
> > > The bug can be triggered in multiple ways, I have seen it when an external
> > > network request is served, when installing packages over the network and
> > > performing a git clone.
> [...]
>
> I missed the upstream follow-up to this, which was commit 58caf637365f
> "Driver: Vmxnet3: Fix regression caused by 5738a09".
>
> I'm attaching a backport of that. I don't have any VMware installation
> to test on; could you do that?

This indeed fixes the issue.

Thomas