From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Ben Hutchings To: linux-kernel@vger.kernel.org, stable@vger.kernel.org CC: akpm@linux-foundation.org, "Michael Schmitz" , "Geert Uytterhoeven" , "David S. Miller" , "Michael Karcher" Date: Sun, 11 Nov 2018 19:49:05 +0000 Message-ID: Subject: [PATCH 3.16 021/366] net-next: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()). In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: 3.16.61-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Michael Karcher commit 9144c3795c2636351d553e4d0fc5297201182de2 upstream. This complements the fix in 82533ad9a1c ("net: ethernet: ax88796: don't call free_irq without request_irq first") that removed the free_irq call in the error path of probe, to also not call free_irq when remove is called to revert the effects of probe. Fixes: 82533ad9a1c (net: ethernet: ax88796: don't call free_irq without request_irq first) Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz Reviewed-by: Geert Uytterhoeven Signed-off-by: David S. Miller Signed-off-by: Ben Hutchings --- drivers/net/ethernet/8390/ax88796.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/net/ethernet/8390/ax88796.c +++ b/drivers/net/ethernet/8390/ax88796.c @@ -812,7 +812,6 @@ static int ax_remove(struct platform_dev struct resource *mem; unregister_netdev(dev); - free_irq(dev->irq, dev); iounmap(ei_local->mem); mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);