From: khalasa@piap.pl (Krzysztof Hałasa)
To: Koen Vandeputte <koen.vandeputte@ncentric.com>
Cc: linux-arm-kernel@lists.infradead.org,
Arnd Bergmann <arnd@arndb.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Olof Johansson <olof@lixom.net>,
Robin Leblon <robin.leblon@ncentric.com>,
Rob Herring <robh@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Tim Harvey <tharvey@gateworks.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] arm: cns3xxx: fix writing to wrong PCI registers after alignment
Date: Thu, 20 Dec 2018 06:34:48 +0100 [thread overview]
Message-ID: <m3ftushibr.fsf@t19.piap.pl> (raw)
In-Reply-To: <20181218111743.25566-1-koen.vandeputte@ncentric.com> (Koen Vandeputte's message of "Tue, 18 Dec 2018 12:17:43 +0100")
Koen Vandeputte <koen.vandeputte@ncentric.com> writes:
> --- a/arch/arm/mach-cns3xxx/pcie.c
> +++ b/arch/arm/mach-cns3xxx/pcie.c
> @@ -83,7 +83,7 @@ static void __iomem *cns3xxx_pci_map_bus(struct pci_bus *bus,
> } else /* remote PCI bus */
> base = cnspci->cfg1_regs + ((busno & 0xf) << 20);
>
> - return base + (where & 0xffc) + (devfn << 12);
> + return base + where + (devfn << 12);
> }
>
> static int cns3xxx_pci_read_config(struct pci_bus *bus, unsigned int devfn,
Acked-by: Krzysztof Halasa <khalasa@piap.pl>
--
Krzysztof Halasa
Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
next prev parent reply other threads:[~2018-12-20 5:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 11:17 [PATCH] arm: cns3xxx: fix writing to wrong PCI registers after alignment Koen Vandeputte
2018-12-18 16:04 ` Tim Harvey
2018-12-20 5:34 ` Krzysztof Hałasa [this message]
2018-12-29 14:40 ` Koen Vandeputte
2018-12-30 1:06 ` Bjorn Helgaas
2018-12-31 10:14 ` Krzysztof Hałasa
2018-12-31 15:29 ` Bjorn Helgaas
2019-01-07 8:58 ` Koen Vandeputte
2019-01-07 13:24 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ftushibr.fsf@t19.piap.pl \
--to=khalasa@piap.pl \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=koen.vandeputte@ncentric.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=olof@lixom.net \
--cc=robh@kernel.org \
--cc=robin.leblon@ncentric.com \
--cc=stable@vger.kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).