public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Yadav <ptyadav@amazon.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: kernel test robot <lkp@intel.com>, <stable@vger.kernel.org>,
	<oe-kbuild-all@lists.linux.dev>
Subject: Re: [PATCH 5.4] cifs/smb3: Fix NULL pointer dereference in smb2_query_info_compound()
Date: Wed, 5 Apr 2023 15:33:20 +0200	[thread overview]
Message-ID: <mafs0jzyqh2sf.fsf_-_@amazon.de> (raw)
In-Reply-To: <2023040528-maroon-running-0fe2@gregkh> (Greg KH's message of "Wed, 5 Apr 2023 14:26:50 +0200")

On Wed, Apr 05 2023, Greg KH wrote:

> On Wed, Apr 05, 2023 at 02:26:04PM +0200, Greg KH wrote:
>> On Wed, Apr 05, 2023 at 01:47:52PM +0200, Pratyush Yadav wrote:
>> > On Wed, Apr 05 2023, kernel test robot wrote:
>> >
>> > > Hi,
>> > >
>> > > Thanks for your patch.
>> > >
>> > > FYI: kernel test robot notices the stable kernel rule is not satisfied.
>> > >
>> > > Rule: 'Cc: stable@vger.kernel.org' or 'commit <sha1> upstream.'
>> >
>> > I think the robot should also learn to look at the 'To:' header :-)
>>
>> Nope, the robot is correct, you submitted this incorrectly.
>
> Wait, maybe, I can't tell.

My point is that it does not matter much if stable@vger.kernel.org is in
Cc or To. It gets the email regardless. In fact, that seems quite a
common practice to me [0][1]. So I'd say it would be nice if the robot
did not needlessly complain about this.

> Please send this again and provide a whole lot more detail as to why
> this is not relevant for upstream.

I went and took another look. It seems that this was also fixed in
upstream but in a slightly different way [2]. I will backport that patch
instead of this one.

[0] https://lore.kernel.org/stable/20230403140414.236685532@linuxfoundation.org/
[1] https://lore.kernel.org/stable/20230403140415.140110769@linuxfoundation.org/
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=87f93d82e0952da18af4d978e7d887b4c5326c0b

-- 
Regards,
Pratyush Yadav



Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879




  reply	other threads:[~2023-04-05 13:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-05 11:42 [PATCH 5.4] cifs/smb3: Fix NULL pointer dereference in smb2_query_info_compound() Pratyush Yadav
2023-04-05 11:44 ` kernel test robot
2023-04-05 11:47   ` Pratyush Yadav
2023-04-05 12:26     ` Greg KH
2023-04-05 12:26       ` Greg KH
2023-04-05 13:33         ` Pratyush Yadav [this message]
2023-04-05 14:22           ` Greg KH
2023-04-12  7:47             ` Yujie Liu
2023-04-12 13:21               ` Pratyush Yadav
2023-04-13  5:49                 ` Yujie Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mafs0jzyqh2sf.fsf_-_@amazon.de \
    --to=ptyadav@amazon.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox