Re: [Intel-gfx] [PATCH] drm/i915: Include asm sources for {ivb, hsw}_clear_kernel.c

[Alexandre Oliva <lxoliva@fsfla.org>]

On Jun  8, 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:

> Quoting Rodrigo Vivi (2020-06-08 18:46:53)
>> Alexandre Oliva has recently removed these files from Linux Libre
>> with concerns that the sources weren't available.
>> 
>> The sources are available on IGT repository, and only open source
>> tools are used to generate the {ivb,hsw}_clear_kernel.c files.
>> 
>> However, the remaining concern from Alexandre Oliva was around
>> GPL license and the source not been present when distributing
>> the code.

Thanks for looking into this, and for addressing the potential issues so
promptly.

>> let's make sure that we do include the asm sources here in our tree.

+1  having sources handy is good!

>> Btw, I tried to have some diligence here and make sure that the
>> asms that these commits are adding are truly the source for
>> the mentioned files:

Excellent!

> Should there not be instructions on how to generate the object code?

Considering that a script is used to generate it, to the point of adding
some of the comments in the output, it might be a good idea to include
it too, especially considering that scripts that control compilation are
part of the complete corresponding source code under the GNU GPL.


IMHO, a link to help users locate the assembler, as comments in the
script, would be welcome, though not mandatory IIUC.  Even though such
links tend to rot over time, they at least offer encouragement to start
or carry on a search ;-)


Thanks again,

-- 
Alexandre Oliva, freedom fighter    he/him    https://FSFLA.org/blogs/lxo/
Free Software Evangelist              Stallman was right, but he's left :(
GNU Toolchain Engineer           Live long and free, and prosper ethically