From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 711A9C433F5
	for <stable@archiver.kernel.org>; Sat, 25 Dec 2021 08:17:24 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231138AbhLYIRY (ORCPT <rfc822;stable@archiver.kernel.org>);
        Sat, 25 Dec 2021 03:17:24 -0500
Received: from smtp-out1.suse.de ([195.135.220.28]:58732 "EHLO
        smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229473AbhLYIRX (ORCPT
        <rfc822;stable@vger.kernel.org>); Sat, 25 Dec 2021 03:17:23 -0500
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
        by smtp-out1.suse.de (Postfix) with ESMTP id A0CDC21112;
        Sat, 25 Dec 2021 08:17:22 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1640420242; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         content-transfer-encoding:content-transfer-encoding:
         in-reply-to:in-reply-to:references:references;
        bh=mk1k6I/mmu4QDll5+IoAgJPUuI3289xMY1Nshnjw8pE=;
        b=J6O8NDHoJMjvQMgr2U+6ooUNHzm8r3F/QwT2y//zGdaggQb8PO3OWe2yYKUozQbhpPJoP8
        a3xtSfs+jlCpIhtbGsgvTf45+tYweonALAUzlvL+sAKnK6XKLX7lL5cWAItZctfOt5WR6D
        d8apn/uUtzeLafqvOjxzH6QZeuYlppU=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1640420242;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         content-transfer-encoding:content-transfer-encoding:
         in-reply-to:in-reply-to:references:references;
        bh=mk1k6I/mmu4QDll5+IoAgJPUuI3289xMY1Nshnjw8pE=;
        b=spfcL9KYwqMXYqxOrAxrMrbMHbP3JDOuu+O0sVpFBuir6F1KWz7jHhrxtOqvgAc9f6wTU0
        lix4F1U76jN/F4CQ==
Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42])
        by relay2.suse.de (Postfix) with ESMTP id 8DF56A3B81;
        Sat, 25 Dec 2021 08:17:22 +0000 (UTC)
Date:   Sat, 25 Dec 2021 09:17:22 +0100
Message-ID: <s5h35mhqest.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Ville Syrjala <ville.syrjala@linux.intel.com>
Cc:     alsa-devel@alsa-project.org, intel-gfx@lists.freedesktop.org,
        stable@vger.kernel.org, Harsha Priya <harshapriya.n@intel.com>,
        Emmanuel Jillela <emmanuel.jillela@intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>
Subject: Re: [PATCH] ALSA: hda/hdmi: Disable silent stream on GLK
In-Reply-To: <20211222145350.24342-1-ville.syrjala@linux.intel.com>
References: <20211222145350.24342-1-ville.syrjala@linux.intel.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
List-ID: <stable.vger.kernel.org>
X-Mailing-List: stable@vger.kernel.org

On Wed, 22 Dec 2021 15:53:50 +0100,
Ville Syrjala wrote:
> 
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> The silent stream stuff recurses back into i915 audio
> component .get_power() from the .pin_eld_notify() hook.
> On GLK this will deadlock as i915 may already be holding
> the relevant modeset locks during .pin_eld_notify() and
> the GLK audio vs. CDCLK workaround will try to grab the
> same locks from .get_power().
> 
> Until someone comes up with a better fix just disable the
> silent stream support on GLK.
> 
> Cc: stable@vger.kernel.org
> Cc: Harsha Priya <harshapriya.n@intel.com>
> Cc: Emmanuel Jillela <emmanuel.jillela@intel.com>
> Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2623
> Fixes: 951894cf30f4 ("ALSA: hda/hdmi: Add Intel silent stream support")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Thanks, applied now.


Takashi