* [PATCH] ALSA: firewire-motu: fix stream format for MOTU 8pre FireWire
@ 2021-06-14 8:31 Takashi Sakamoto
2021-06-17 10:06 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Takashi Sakamoto @ 2021-06-14 8:31 UTC (permalink / raw)
To: tiwai; +Cc: clemens, alsa-devel, stable
My previous refactoring for ALSA firewire-motu driver brought regression
to handle MOTU 8pre FireWire. The packet format is not operated correctly.
Cc: <stable@vger.kernel.org>
Fixes: dfbaa4dc11eb ("ALSA: firewire-motu: add model-specific table of chunk count")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
sound/firewire/motu/motu-protocol-v2.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/sound/firewire/motu/motu-protocol-v2.c b/sound/firewire/motu/motu-protocol-v2.c
index e59e69ab1538..784073aa1026 100644
--- a/sound/firewire/motu/motu-protocol-v2.c
+++ b/sound/firewire/motu/motu-protocol-v2.c
@@ -353,6 +353,7 @@ const struct snd_motu_spec snd_motu_spec_8pre = {
.protocol_version = SND_MOTU_PROTOCOL_V2,
.flags = SND_MOTU_SPEC_RX_MIDI_2ND_Q |
SND_MOTU_SPEC_TX_MIDI_2ND_Q,
- .tx_fixed_pcm_chunks = {10, 6, 0},
- .rx_fixed_pcm_chunks = {10, 6, 0},
+ // Two dummy chunks always in the end of data block.
+ .tx_fixed_pcm_chunks = {10, 10, 0},
+ .rx_fixed_pcm_chunks = {6, 6, 0},
};
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: firewire-motu: fix stream format for MOTU 8pre FireWire
2021-06-14 8:31 [PATCH] ALSA: firewire-motu: fix stream format for MOTU 8pre FireWire Takashi Sakamoto
@ 2021-06-17 10:06 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2021-06-17 10:06 UTC (permalink / raw)
To: Takashi Sakamoto; +Cc: clemens, alsa-devel, stable
On Mon, 14 Jun 2021 10:31:33 +0200,
Takashi Sakamoto wrote:
>
> My previous refactoring for ALSA firewire-motu driver brought regression
> to handle MOTU 8pre FireWire. The packet format is not operated correctly.
>
> Cc: <stable@vger.kernel.org>
> Fixes: dfbaa4dc11eb ("ALSA: firewire-motu: add model-specific table of chunk count")
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-17 10:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-14 8:31 [PATCH] ALSA: firewire-motu: fix stream format for MOTU 8pre FireWire Takashi Sakamoto
2021-06-17 10:06 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox