From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: clemens@ladisch.de, alsa-devel@alsa-project.org, stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: oxfw: fix functioal regression for silence in Apogee Duet FireWire
Date: Thu, 12 Aug 2021 13:40:51 +0200 [thread overview]
Message-ID: <s5him0aj3gc.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210812022839.42043-1-o-takashi@sakamocchi.jp>
On Thu, 12 Aug 2021 04:28:39 +0200,
Takashi Sakamoto wrote:
>
> OXFW 971 has no function to use the value in syt field of received
> isochronous packet for playback timing generation. In kernel prepatch for
> v5.14, ALSA OXFW driver got change to send NO_INFO value in the field
> instead of actual timing value. The change brings Apogee Duet FireWire to
> generate no playback sound, while output meter moves.
>
> As long as I investigate, _any_ value in the syt field takes the device to
> generate sound. It's reasonable to think that the device just ignores data
> blocks in packet with NO_INFO value in its syt field for audio data
> processing.
>
> This commit adds a new flag for the quirk to fix regression.
>
> Fixes: 029ffc429440 ("ALSA: oxfw: perform sequence replay for media clock recovery")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2021-08-12 11:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 2:28 [PATCH] ALSA: oxfw: fix functioal regression for silence in Apogee Duet FireWire Takashi Sakamoto
2021-08-12 11:40 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5him0aj3gc.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=o-takashi@sakamocchi.jp \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox