From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13067C433E0 for ; Mon, 3 Aug 2020 17:40:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 044C922BEF for ; Mon, 3 Aug 2020 17:40:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726624AbgHCRkq (ORCPT ); Mon, 3 Aug 2020 13:40:46 -0400 Received: from mx2.suse.de ([195.135.220.15]:57262 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725945AbgHCRkq (ORCPT ); Mon, 3 Aug 2020 13:40:46 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 29F34B677; Mon, 3 Aug 2020 17:41:00 +0000 (UTC) Date: Mon, 03 Aug 2020 19:40:44 +0200 Message-ID: From: Takashi Iwai To: Pierre-Louis Bossart Cc: Hui Wang , alsa-devel@alsa-project.org, stable@vger.kernel.org Subject: Re: [PATCH] Revert "ALSA: hda: call runtime_allow() for all hda controllers" In-Reply-To: <6f583ccc-2251-384d-bc20-aa17c83a45b4@linux.intel.com> References: <20200803064638.6139-1-hui.wang@canonical.com> <0db4f5fe-7895-2d00-8ce3-96f1245000ab@linux.intel.com> <6f583ccc-2251-384d-bc20-aa17c83a45b4@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, 03 Aug 2020 19:00:30 +0200, Pierre-Louis Bossart wrote: > > > > On 8/3/20 11:36 AM, Takashi Iwai wrote: > > On Mon, 03 Aug 2020 17:27:12 +0200, > > Pierre-Louis Bossart wrote: > >> > >> > >> > >> On 8/3/20 1:46 AM, Hui Wang wrote: > >>> This reverts commit 9a6418487b56 ("ALSA: hda: call runtime_allow() > >>> for all hda controllers"). > >>> > >>> The reverted patch already introduced some regressions on some > >>> machines: > >>> - on gemini-lake machines, the error of "azx_get_response timeout" > >>> happens in the hda driver. > >>> - on the machines with alc662 codec, the audio jack detection doesn't > >>> work anymore. > >>> > >>> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=208511 > >>> Cc: > >>> Signed-off-by: Hui Wang > >>> --- > >>> sound/pci/hda/hda_intel.c | 1 - > >>> 1 file changed, 1 deletion(-) > >>> > >>> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > >>> index e699873c8293..e34a4d5d047c 100644 > >>> --- a/sound/pci/hda/hda_intel.c > >>> +++ b/sound/pci/hda/hda_intel.c > >>> @@ -2352,7 +2352,6 @@ static int azx_probe_continue(struct azx *chip) > >>> if (azx_has_pm_runtime(chip)) { > >>> pm_runtime_use_autosuspend(&pci->dev); > >>> - pm_runtime_allow(&pci->dev); > >>> pm_runtime_put_autosuspend(&pci->dev); > >>> } > >> > >> Do I get this right that this permanently disables pm_runtime on all > >> Intel HDaudio controllers? > > > > It just drops the unconditional enablement of runtime PM. > > It can be enabled via sysfs, and that's the old default (let admin > > enabling it via udev or whatever). > > Sorry I am confused now. > Kai seemed to suggest in the Bugzilla comments that this would be > temporary, until these problems with i915 and ALC662 get fixed? Right, that's the plan. This patch revert to the old state before the forced-all-enable call we've taken in 5.7. On 5.7 and onwards, all HD-audio controllers are enforced to use the runtime PM. Before that version, the runtime PM was enabled *as default* only for limited devices (typically the ones bound with GPU); for other devices, the runtime PM is manually enabled from user-space via sysfs (and many distros enable them in anyway). The forced enablement was merged with a hope that now all HD-audio controllers behave nicely, but it turned out to cause a regression, so it was reverted. Once when we find out the real cause, we can flip the flag again. Takashi