From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 9BA29C433F5
	for <stable@archiver.kernel.org>; Sat, 19 Mar 2022 08:11:03 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S237622AbiCSIMV (ORCPT <rfc822;stable@archiver.kernel.org>);
        Sat, 19 Mar 2022 04:12:21 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47102 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233088AbiCSIMU (ORCPT
        <rfc822;stable@vger.kernel.org>); Sat, 19 Mar 2022 04:12:20 -0400
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40557DA6C4;
        Sat, 19 Mar 2022 01:10:59 -0700 (PDT)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
        by smtp-out1.suse.de (Postfix) with ESMTP id DC4C9210FC;
        Sat, 19 Mar 2022 08:10:57 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1647677457; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=oXIWQQqU9rvgrRuKG2gXszHtE9y6LE6bzP/JEXWGAD0=;
        b=M4MRHoYhS/sH4jY60YUxGv75z1fIGm+52YRaFCb+Ky8VPhzEpBOcnIroqbndZVvvNSjPKr
        DwJO1rPrFByfQ5eS6nfz/qrtwAlnOwflhtUnElo0/p7aARp3tvlE6/ONKpm7Sb74SfElTi
        8D6woefJxBtnb4SLx2KqGgBKU5lrCD4=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1647677457;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=oXIWQQqU9rvgrRuKG2gXszHtE9y6LE6bzP/JEXWGAD0=;
        b=1tZJyOl/BKPqXP9MMRrp8vcfSA56Tryvn/N6NukV+mZQlWuqWcG9ldDU5taHRYGmC96zdp
        Y7W1qEmO+PAFzhAg==
Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42])
        by relay2.suse.de (Postfix) with ESMTP id B8EC1A3B83;
        Sat, 19 Mar 2022 08:10:57 +0000 (UTC)
Date:   Sat, 19 Mar 2022 09:10:57 +0100
Message-ID: <s5hlex61hwu.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc:     Takashi Iwai <tiwai@suse.de>,
        =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>,
        linux-input@vger.kernel.org,
        Peter Hutterer <peter.hutterer@who-t.net>,
        Jiri Kosina <jkosina@suse.cz>, stable@vger.kernel.org,
        regressions@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION] Right touchpad button disabled on Dell 7750
In-Reply-To: <CAO-hwJK8QMjYhQAC8tp7hLWZjSB3JMBJXgpKmFZRSEqPUn3_iw@mail.gmail.com>
References: <s5htubv32s8.wl-tiwai@suse.de>
        <20220318130740.GA33535@elementary>
        <s5hlex72yno.wl-tiwai@suse.de>
        <CAO-hwJK8QMjYhQAC8tp7hLWZjSB3JMBJXgpKmFZRSEqPUn3_iw@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <stable.vger.kernel.org>
X-Mailing-List: stable@vger.kernel.org

On Fri, 18 Mar 2022 15:06:55 +0100,
Benjamin Tissoires wrote:
> 
> As noticed on the libinput bug, I think the patch is wrong (not by a lot).
> We should base the class on MT_CLS_WIN8, not MT_CLS_DEFAULT.
> 
> The testers might say that it's working, but this might create some
> corner cases where it's not leading to more and more headaches with
> your users.

Indeed the first patch caused the wrong button mapping.
Jose's revised patch was confirmed to work fine.


thanks,

Takashi