From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=X/91=3D=vger.kernel.org=stable-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 83859C33CB1
	for <stable@archiver.kernel.org>; Tue, 14 Jan 2020 08:42:33 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 611772084D
	for <stable@archiver.kernel.org>; Tue, 14 Jan 2020 08:42:33 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1725842AbgANImc (ORCPT <rfc822;stable@archiver.kernel.org>);
        Tue, 14 Jan 2020 03:42:32 -0500
Received: from mx2.suse.de ([195.135.220.15]:34582 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726195AbgANImc (ORCPT <rfc822;stable@vger.kernel.org>);
        Tue, 14 Jan 2020 03:42:32 -0500
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.220.254])
        by mx2.suse.de (Postfix) with ESMTP id E7998AF65;
        Tue, 14 Jan 2020 08:42:30 +0000 (UTC)
Date:   Tue, 14 Jan 2020 09:42:30 +0100
Message-ID: <s5hmuaqfmyx.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Johan Hovold <johan@kernel.org>
Cc:     Jaroslav Kysela <perex@perex.cz>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, stable <stable@vger.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: fix sync-ep altsetting sanity check
In-Reply-To: <20200114083953.1106-1-johan@kernel.org>
References: <20200114083953.1106-1-johan@kernel.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: stable-owner@vger.kernel.org
Precedence: bulk
List-ID: <stable.vger.kernel.org>
X-Mailing-List: stable@vger.kernel.org

On Tue, 14 Jan 2020 09:39:53 +0100,
Johan Hovold wrote:
> 
> The altsetting sanity check in set_sync_ep_implicit_fb_quirk() was
> checking for there to be at least one altsetting but then went on to
> access the second one, which may not exist.
> 
> This could lead to random slab data being used to initialise the sync
> endpoint in snd_usb_add_endpoint().
> 
> Fixes: c75a8a7ae565 ("ALSA: snd-usb: add support for implicit feedback")
> Fixes: ca10a7ebdff1 ("ALSA: usb-audio: FT C400 sync playback EP to capture EP")
> Fixes: 5e35dc0338d8 ("ALSA: usb-audio: add implicit fb quirk for Behringer UFX1204")
> Fixes: 17f08b0d9aaf ("ALSA: usb-audio: add implicit fb quirk for Axe-Fx II")
> Fixes: 103e9625647a ("ALSA: usb-audio: simplify set_sync_ep_implicit_fb_quirk")
> Cc: stable <stable@vger.kernel.org>     # 3.5
> Signed-off-by: Johan Hovold <johan@kernel.org>

Thanks, applied now.


Takashi