From: Takashi Iwai <tiwai@suse.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] Input: elants_i2c - Fix NULL dereference at probing
Date: Thu, 27 May 2021 08:20:25 +0200 [thread overview]
Message-ID: <s5ho8cw8zpy.wl-tiwai@suse.de> (raw)
In-Reply-To: <YK6tZy3E/XZpOAbh@google.com>
On Wed, 26 May 2021 22:19:51 +0200,
Dmitry Torokhov wrote:
>
> Hi Takashi,
>
> On Wed, May 26, 2021 at 09:43:01PM +0200, Takashi Iwai wrote:
> > The recent change in elants_i2c driver to support more chips
> > introduced a regression leading to Oops at probing. The driver reads
> > id->driver_data, but the id may be NULL depending on the device type
> > the driver gets bound.
> >
> > Add a NULL check and falls back to the default EKTH3500.
>
> Thank you for the patch. I think my preference would be to switch to
> device_get_match_data() and annotate the rest of the match tables with
> proper controller types.
OK, that sounds feasible. Shall I submit a revised patch?
Takashi
prev parent reply other threads:[~2021-05-27 6:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 19:43 [PATCH] Input: elants_i2c - Fix NULL dereference at probing Takashi Iwai
2021-05-26 20:19 ` Dmitry Torokhov
2021-05-26 20:44 ` Dmitry Osipenko
2021-05-27 6:22 ` Takashi Iwai
2021-05-27 19:01 ` Dmitry Osipenko
2021-05-27 6:20 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5ho8cw8zpy.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox