stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Hui Wang <hui.wang@canonical.com>
Cc: alsa-devel@alsa-project.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] ALSA: hda - Add mic mute hotkey quirk for Lenovo ThinkCentre AIO
Date: Thu, 24 Dec 2015 07:44:22 +0100	[thread overview]
Message-ID: <s5hvb7ouz09.wl-tiwai@suse.de> (raw)
In-Reply-To: <1450928798-31191-1-git-send-email-hui.wang@canonical.com>

On Thu, 24 Dec 2015 04:46:37 +0100,
Hui Wang wrote:
> 
> From: Kailang <kailang@realtek.com>
> 
> The Lenovo ThinkCenter AIO uses Line2 (NID 0x1b) to implement the
> micmute hotkey, here we register an input device and use Line2 unsol
> event to collect the hotkey pressing or releasing.
> 
> In the meanwhile, the micmute led is controlled by GPIO2, so we
> use an existing function alc_fixup_gpio_mic_mute_hook() to control
> the led.
> 
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Kailang <kailang@realtek.com>

Is it mandatory expose this as a key event?  I mean, wouldn't it
suffice just toggle the mic mute by the driver itself?  User-space
will get the notification by the mixer status change in anyway.


Takashi

  parent reply	other threads:[~2015-12-24  6:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-24  3:46 [PATCH 1/2] ALSA: hda - Add mic mute hotkey quirk for Lenovo ThinkCentre AIO Hui Wang
2015-12-24  3:46 ` [PATCH 2/2] ALSA: hda - Add keycode map for alc input device Hui Wang
2015-12-25  7:51   ` Takashi Iwai
2015-12-28  3:04     ` [alsa-devel] " Hui Wang
2015-12-24  6:44 ` Takashi Iwai [this message]
2015-12-24  7:45   ` [PATCH 1/2] ALSA: hda - Add mic mute hotkey quirk for Lenovo ThinkCentre AIO Takashi Iwai
2015-12-24  9:39     ` [alsa-devel] " Hui Wang
2015-12-24 13:03       ` Takashi Iwai
2015-12-25  2:19         ` Hui Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hvb7ouz09.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=hui.wang@canonical.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).