From: "Wentao Guan" <guanwentao@uniontech.com>
To: "Greg KH" <gregkh@linuxfoundation.org>
Cc: oneukum <oneukum@suse.com>, carvsdriver <carvsdriver@gmail.com>,
linux-usb <linux-usb@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH RFC] USB: cdc-acm: Fix bit overlap and move quirk definitions to header
Date: Thu, 21 May 2026 23:03:02 +0800 [thread overview]
Message-ID: <tencent_59BCDC255EB2B97F0CAB385D@qq.com> (raw)
In-Reply-To: <2026052144-unwritten-washing-df27@gregkh>
> On Wed, May 06, 2026 at 05:32:13PM +0800, Wentao Guan wrote:
> > The VENDOR_CLASS_DATA_IFACE and ALWAYS_POLL_CTRL quirk flags added in
> > commit f58752ebcb35 ("USB: cdc-acm: Add quirks for Yoga Book 9 14IAH10
> > INGENIC touchscreen") were placed inside the acm_ctrl_msg() function
> > rather than in the header with the other quirk flags. Then, their
> > values (BIT(9) and BIT(10)) collided with NO_UNION_12 which is already
> > BIT(9).
> >
> > Move the definitions to drivers/usb/class/cdc-acm.h where they belong
> > and shift them to BIT(10) and BIT(11) to avoid the overlap.
> >
> > Fixes: f58752ebcb35 ("USB: cdc-acm: Add quirks for Yoga Book 9 14IAH10 INGENIC touchscreen")
> > Cc: stable@vger.kernel.org
>
> Why is this needed for stable? What bug does this "fix"?
I see that there is a bug that NO_UNION_12 and VENDOR_CLASS_DATA_IFACE use same bit.
BRs
Wentao Guan
next prev parent reply other threads:[~2026-05-21 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 9:32 [PATCH RFC] USB: cdc-acm: Fix bit overlap and move quirk definitions to header Wentao Guan
2026-05-21 14:55 ` Greg KH
2026-05-21 15:03 ` Wentao Guan [this message]
2026-05-22 4:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_59BCDC255EB2B97F0CAB385D@qq.com \
--to=guanwentao@uniontech.com \
--cc=carvsdriver@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox