public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: "driz2t@qq.com" <driz2t@qq.com>
To: "stable@vger.kernel.org" <stable@vger.kernel.org>
Cc: "xiang@kernel.org" <xiang@kernel.org>,
	"chao@kernel.org" <chao@kernel.org>,
	"huyue2@coolpad.com" <huyue2@coolpad.com>,
	"jefflexu@linux.alibaba.com" <jefflexu@linux.alibaba.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"syzbot+016d861797fd718491a8@syzkaller.appspotmail.com"
	<syzbot+016d861797fd718491a8@syzkaller.appspotmail.com>
Subject: [PATCH 6.1.y] erofs: get rid of z_erofs_fill_inode()
Date: Wed, 25 Mar 2026 06:57:41 +0000	[thread overview]
Message-ID: <tencent_9245CADBF1A8EA39C72025351E3BAE7F130A@qq.com> (raw)

This is a backport of upstream commit 4fdadd5b0f0c723c812842454f8cca1619f2e731.
(erofs: get rid of z_erofs_fill_inode())

Reported-by: syzbot+016d861797fd718491a8@syzkaller.appspotmail.com
Tested-by: syzbot+016d861797fd718491a8@syzkaller.appspotmail.com
Signed-off-by: Changjian Liu <driz2t@qq.com>
---
 fs/erofs/inode.c     |  12 ++++++++----
 fs/erofs/internal.h  |   2 --
 fs/erofs/zmap.c      |  18 ------------------
 scripts/extract-cert | Bin 0 -> 14608 bytes
 4 files changed, 8 insertions(+), 24 deletions(-)
 create mode 100755 scripts/extract-cert

diff --git a/fs/erofs/inode.c b/fs/erofs/inode.c
index 3cbef6318b7b..484572504b4d 100644
--- a/fs/erofs/inode.c
+++ b/fs/erofs/inode.c
@@ -280,11 +280,15 @@ static int erofs_fill_inode(struct inode *inode)
      }
 
      if (erofs_inode_is_data_compressed(vi->datalayout)) {
+#ifdef CONFIG_EROFS_FS_ZIP
            if (!erofs_is_fscache_mode(inode->i_sb) &&
-               inode->i_sb->s_blocksize_bits == PAGE_SHIFT)
-                 err = z_erofs_fill_inode(inode);
-           else
-                 err = -EOPNOTSUPP;
+               inode->i_sb->s_blocksize_bits == PAGE_SHIFT) {
+                 inode->i_mapping->a_ops = &z_erofs_aops;
+                 err = 0;
+                 goto out_unlock;
+           }
+#endif
+           err = -EOPNOTSUPP;
            goto out_unlock;
      }
      inode->i_mapping->a_ops = &erofs_raw_access_aops;
diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
index 126970932805..1a4d08a93339 100644
--- a/fs/erofs/internal.h
+++ b/fs/erofs/internal.h
@@ -423,12 +423,10 @@ enum {
 extern const struct iomap_ops z_erofs_iomap_report_ops;
 
 #ifdef CONFIG_EROFS_FS_ZIP
-int z_erofs_fill_inode(struct inode *inode);
 int z_erofs_map_blocks_iter(struct inode *inode,
                      struct erofs_map_blocks *map,
                      int flags);
 #else
-static inline int z_erofs_fill_inode(struct inode *inode) { return -EOPNOTSUPP; }
 static inline int z_erofs_map_blocks_iter(struct inode *inode,
                                struct erofs_map_blocks *map,
                                int flags)
diff --git a/fs/erofs/zmap.c b/fs/erofs/zmap.c
index d2d7fe826091..ff84533da0c4 100644
--- a/fs/erofs/zmap.c
+++ b/fs/erofs/zmap.c
@@ -7,24 +7,6 @@
 #include <asm/unaligned.h>
 #include <trace/events/erofs.h>
 
-int z_erofs_fill_inode(struct inode *inode)
-{
-     struct erofs_inode *const vi = EROFS_I(inode);
-     struct erofs_sb_info *sbi = EROFS_SB(inode->i_sb);
-
-     if (!erofs_sb_has_big_pcluster(sbi) &&
-         !erofs_sb_has_ztailpacking(sbi) && !erofs_sb_has_fragments(sbi) &&
-         vi->datalayout == EROFS_INODE_COMPRESSED_FULL) {
-           vi->z_advise = 0;
-           vi->z_algorithmtype[0] = 0;
-           vi->z_algorithmtype[1] = 0;
-           vi->z_logical_clusterbits = inode->i_sb->s_blocksize_bits;
-           set_bit(EROFS_I_Z_INITED_BIT, &vi->flags);
-     }
-     inode->i_mapping->a_ops = &z_erofs_aops;
-     return 0;
-}
-
 struct z_erofs_maprecorder {
      struct inode *inode;
      struct erofs_map_blocks *map;
-- 
2.43.0

             reply	other threads:[~2026-03-25  6:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25  6:57 driz2t [this message]
2026-03-25  7:15 ` [PATCH 6.1.y] erofs: get rid of z_erofs_fill_inode() Gao Xiang
  -- strict thread matches above, loose matches on Subject: below --
2026-03-25 11:11 driz2t
2026-03-24 12:48 driz2t

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_9245CADBF1A8EA39C72025351E3BAE7F130A@qq.com \
    --to=driz2t@qq.com \
    --cc=chao@kernel.org \
    --cc=huyue2@coolpad.com \
    --cc=jefflexu@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=syzbot+016d861797fd718491a8@syzkaller.appspotmail.com \
    --cc=xiang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox