stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [tip:x86/urgent] x86, efi: Don't use (U) EFI time services on 32 bit
       [not found] <1385754283-2464-1-git-send-email-matthew.garrett@nebula.com>
@ 2013-12-10 23:22 ` tip-bot for Matthew Garrett
  0 siblings, 0 replies; only message in thread
From: tip-bot for Matthew Garrett @ 2013-12-10 23:22 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, hpa, mingo, matthew.garrett, stable, matt.fleming,
	tglx, hpa

Commit-ID:  04bf9ba720fcc4fa313fa122b799ae0989b6cd50
Gitweb:     http://git.kernel.org/tip/04bf9ba720fcc4fa313fa122b799ae0989b6cd50
Author:     Matthew Garrett <matthew.garrett@nebula.com>
AuthorDate: Fri, 29 Nov 2013 14:44:43 -0500
Committer:  H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Tue, 10 Dec 2013 15:02:34 -0800

x86, efi: Don't use (U)EFI time services on 32 bit

UEFI time services are often broken once we're in virtual mode. We were
already refusing to use them on 64-bit systems, but it turns out that
they're also broken on some 32-bit firmware, including the Dell Venue.
Disable them for now, we can revisit once we have the 1:1 mappings code
incorporated.

Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>
Link: http://lkml.kernel.org/r/1385754283-2464-1-git-send-email-matthew.garrett@nebula.com
Cc: <stable@vger.kernel.org>
Cc: Matt Fleming <matt.fleming@intel.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
 arch/x86/platform/efi/efi.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index 92c0234..cceb813 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -690,13 +690,6 @@ void __init efi_init(void)
 
 	set_bit(EFI_MEMMAP, &x86_efi_facility);
 
-#ifdef CONFIG_X86_32
-	if (efi_is_native()) {
-		x86_platform.get_wallclock = efi_get_time;
-		x86_platform.set_wallclock = efi_set_rtc_mmss;
-	}
-#endif
-
 #if EFI_DEBUG
 	print_efi_memmap();
 #endif

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2013-12-10 23:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1385754283-2464-1-git-send-email-matthew.garrett@nebula.com>
2013-12-10 23:22 ` [tip:x86/urgent] x86, efi: Don't use (U) EFI time services on 32 bit tip-bot for Matthew Garrett

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).