From: tip-bot for Matt Fleming <matt.fleming@intel.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
mjg59@srcf.ucam.org, stable@vger.kernel.org,
corentincj@iksaif.net, matt.fleming@intel.com,
steve.langasek@canonical.com, colin.king@canonical.com,
tglx@linutronix.de, hpa@linux.intel.com
Subject: [tip:x86/urgent] samsung-laptop: Disable on EFI hardware
Date: Wed, 30 Jan 2013 10:36:37 -0800 [thread overview]
Message-ID: <tip-309176501502073be48627b4e6196e8f0cc2ea60@git.kernel.org> (raw)
In-Reply-To: <1358800838-10459-3-git-send-email-matt@console-pimps.org>
Commit-ID: 309176501502073be48627b4e6196e8f0cc2ea60
Gitweb: http://git.kernel.org/tip/309176501502073be48627b4e6196e8f0cc2ea60
Author: Matt Fleming <matt.fleming@intel.com>
AuthorDate: Mon, 21 Jan 2013 20:40:38 +0000
Committer: H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Wed, 30 Jan 2013 08:58:36 -0800
samsung-laptop: Disable on EFI hardware
It has been reported that running this driver on some Samsung laptops
with EFI can cause those machines to become bricked as detailed in the
following report,
https://bugs.launchpad.net/ubuntu-cdimage/+bug/1040557
There have also been reports of this driver causing Machine Check
Exceptions on recent EFI-enabled Samsung laptops,
https://bugzilla.kernel.org/show_bug.cgi?id=47121
So disable it if booting from EFI since this driver relies on
grovelling around in the BIOS memory map which isn't going to work.
Cc: Corentin Chary <corentincj@iksaif.net>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Colin Ian King <colin.king@canonical.com>
Cc: Steve Langasek <steve.langasek@canonical.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Link: http://lkml.kernel.org/r/1358800838-10459-3-git-send-email-matt@console-pimps.org
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
drivers/platform/x86/samsung-laptop.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
index 71623a2..0ffcfc4 100644
--- a/drivers/platform/x86/samsung-laptop.c
+++ b/drivers/platform/x86/samsung-laptop.c
@@ -1544,6 +1544,9 @@ static int __init samsung_init(void)
struct samsung_laptop *samsung;
int ret;
+ if (efi_enabled(EFI_BOOT))
+ return -ENODEV;
+
quirks = &samsung_unknown;
if (!force && !dmi_check_system(samsung_dmi_table))
return -ENODEV;
prev parent reply other threads:[~2013-01-30 18:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1358800838-10459-1-git-send-email-matt@console-pimps.org>
2013-01-21 20:40 ` [PATCH 1/2] efi: Make 'efi_enabled' a function to query EFI facilities Matt Fleming
2013-01-21 20:42 ` H. Peter Anvin
2013-01-21 21:12 ` Matt Fleming
2013-01-23 4:16 ` Ben Hutchings
2013-01-23 7:52 ` Matt Fleming
2013-01-23 13:17 ` Ben Hutchings
2013-01-25 23:53 ` Matt Fleming
2013-01-21 20:54 ` Dave Jiang
2013-01-21 20:56 ` Matthew Garrett
2013-01-30 18:35 ` [tip:x86/urgent] " tip-bot for Matt Fleming
2013-01-21 20:40 ` [PATCH 2/2] samsung-laptop: Disable on EFI hardware Matt Fleming
2013-01-30 18:36 ` tip-bot for Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-309176501502073be48627b4e6196e8f0cc2ea60@git.kernel.org \
--to=matt.fleming@intel.com \
--cc=colin.king@canonical.com \
--cc=corentincj@iksaif.net \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=stable@vger.kernel.org \
--cc=steve.langasek@canonical.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox