stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] x86, mm: add parenthesis for TLB tracepoint size calculation
@ 2015-07-20 23:01 Dave Hansen
  2015-07-21  9:36 ` [tip:x86/urgent] x86/mm: Add " tip-bot for Dave Hansen
  0 siblings, 1 reply; 2+ messages in thread
From: Dave Hansen @ 2015-07-20 23:01 UTC (permalink / raw)
  To: dave; +Cc: dave.hansen, x86, linux-kernel, stable


From: Dave Hansen <dave.hansen@linux.intel.com>

flush_tlb_info->flush_start/end are both normal virtual
addresses.  When calculating 'nr_pages' (only used for the
tracepoint), I neglected to put parenthesis in.

Thanks to David Koufaty for pointing this out.

Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
---

 b/arch/x86/mm/tlb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN arch/x86/mm/tlb.c~tlb-parens arch/x86/mm/tlb.c
--- a/arch/x86/mm/tlb.c~tlb-parens	2015-07-20 15:37:33.951272224 -0700
+++ b/arch/x86/mm/tlb.c	2015-07-20 15:37:33.955272406 -0700
@@ -117,7 +117,7 @@ static void flush_tlb_func(void *info)
 		} else {
 			unsigned long addr;
 			unsigned long nr_pages =
-				f->flush_end - f->flush_start / PAGE_SIZE;
+				(f->flush_end - f->flush_start) / PAGE_SIZE;
 			addr = f->flush_start;
 			while (addr < f->flush_end) {
 				__flush_tlb_single(addr);
_

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:x86/urgent] x86/mm: Add parenthesis for TLB tracepoint size calculation
  2015-07-20 23:01 [PATCH] x86, mm: add parenthesis for TLB tracepoint size calculation Dave Hansen
@ 2015-07-21  9:36 ` tip-bot for Dave Hansen
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Dave Hansen @ 2015-07-21  9:36 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: mingo, dave.hansen, torvalds, hpa, tglx, linux-kernel, peterz,
	akpm, stable

Commit-ID:  bbc03778b9954a2ec93baed63718e4df0192f130
Gitweb:     http://git.kernel.org/tip/bbc03778b9954a2ec93baed63718e4df0192f130
Author:     Dave Hansen <dave.hansen@linux.intel.com>
AuthorDate: Mon, 20 Jul 2015 16:01:53 -0700
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 21 Jul 2015 07:45:50 +0200

x86/mm: Add parenthesis for TLB tracepoint size calculation

flush_tlb_info->flush_start/end are both normal virtual
addresses.  When calculating 'nr_pages' (only used for the
tracepoint), I neglected to put parenthesis in.

Thanks to David Koufaty for pointing this out.

Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: dave@sr71.net
Cc: <stable@vger.kernel.org>
Link: http://lkml.kernel.org/r/20150720230153.9E834081@viggo.jf.intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/mm/tlb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
index 3250f23..90b924a 100644
--- a/arch/x86/mm/tlb.c
+++ b/arch/x86/mm/tlb.c
@@ -117,7 +117,7 @@ static void flush_tlb_func(void *info)
 		} else {
 			unsigned long addr;
 			unsigned long nr_pages =
-				f->flush_end - f->flush_start / PAGE_SIZE;
+				(f->flush_end - f->flush_start) / PAGE_SIZE;
 			addr = f->flush_start;
 			while (addr < f->flush_end) {
 				__flush_tlb_single(addr);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-07-21  9:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-20 23:01 [PATCH] x86, mm: add parenthesis for TLB tracepoint size calculation Dave Hansen
2015-07-21  9:36 ` [tip:x86/urgent] x86/mm: Add " tip-bot for Dave Hansen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).