[REGRESSION] ThinkPad L15 Gen 4 touchpad no longer works

[REGRESSION] ThinkPad L15 Gen 4 touchpad no longer works

[Ulrich Müller]

After upgrading from 6.6.52 to 6.6.58, tapping on the touchpad stopped
working. The problem is still present in 6.6.59.

I see the following in dmesg output; the first line was not there
previously:

[    2.129282] hid-multitouch 0018:27C6:01E0.0001: The byte is not expected for fixing the report descriptor. It's possible that the touchpad firmware is not suitable for applying the fix. got: 9
[    2.137479] input: GXTP5140:00 27C6:01E0 as /devices/platform/AMDI0010:00/i2c-0/i2c-GXTP5140:00/0018:27C6:01E0.0001/input/input10
[    2.137680] input: GXTP5140:00 27C6:01E0 as /devices/platform/AMDI0010:00/i2c-0/i2c-GXTP5140:00/0018:27C6:01E0.0001/input/input11
[    2.137921] hid-multitouch 0018:27C6:01E0.0001: input,hidraw0: I2C HID v1.00 Mouse [GXTP5140:00 27C6:01E0] on i2c-GXTP5140:00

Hardware is a Lenovo ThinkPad L15 Gen 4.

The problem goes away when reverting this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/hid/hid-multitouch.c?id=251efae73bd46b097deec4f9986d926813aed744

See also Gentoo bug report: https://bugs.gentoo.org/942797

Re: [REGRESSION] ThinkPad L15 Gen 4 touchpad no longer works

[Ulrich Müller]

>>>>> On Sun, 03 Nov 2024, Ulrich Müller wrote:

> After upgrading from 6.6.52 to 6.6.58, tapping on the touchpad stopped
> working. The problem is still present in 6.6.59.

> I see the following in dmesg output; the first line was not there
> previously:

> [    2.129282] hid-multitouch 0018:27C6:01E0.0001: The byte is not expected for fixing the report descriptor. It's possible that the touchpad firmware is not suitable for applying the fix. got: 9
> [    2.137479] input: GXTP5140:00 27C6:01E0 as /devices/platform/AMDI0010:00/i2c-0/i2c-GXTP5140:00/0018:27C6:01E0.0001/input/input10
> [    2.137680] input: GXTP5140:00 27C6:01E0 as /devices/platform/AMDI0010:00/i2c-0/i2c-GXTP5140:00/0018:27C6:01E0.0001/input/input11
> [    2.137921] hid-multitouch 0018:27C6:01E0.0001: input,hidraw0: I2C HID v1.00 Mouse [GXTP5140:00 27C6:01E0] on i2c-GXTP5140:00

> Hardware is a Lenovo ThinkPad L15 Gen 4.

> The problem goes away when reverting this commit:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/hid/hid-multitouch.c?id=251efae73bd46b097deec4f9986d926813aed744

Also, it looks like that commit conflated two independent changes:
- It adds some code for I2C_DEVICE_ID_GOODIX_01E0.
- It changes 01E8 (which was duplicate before) to 01E9 in line 2068.

Of course, reverting the first part is enough to fix the problem here.
The revert is now included in Gentoo's sys-kernel/gentoo-sources:
https://gitweb.gentoo.org/proj/linux-patches.git/tree/2600_HID-revert-Y900P-fix-ThinkPad-L15-touchpad.patch?h=6.6-68

> See also Gentoo bug report: https://bugs.gentoo.org/942797

Re: [REGRESSION] ThinkPad L15 Gen 4 touchpad no longer works

[Linux regression tracking (Thorsten Leemhuis)]

On 03.11.24 09:24, Ulrich Müller wrote:
> After upgrading from 6.6.52 to 6.6.58, tapping on the touchpad stopped
> working. The problem is still present in 6.6.59.
> 
> I see the following in dmesg output; the first line was not there
> previously:
> 
> [    2.129282] hid-multitouch 0018:27C6:01E0.0001: The byte is not expected for fixing the report descriptor. It's possible that the touchpad firmware is not suitable for applying the fix. got: 9
> [    2.137479] input: GXTP5140:00 27C6:01E0 as /devices/platform/AMDI0010:00/i2c-0/i2c-GXTP5140:00/0018:27C6:01E0.0001/input/input10
> [    2.137680] input: GXTP5140:00 27C6:01E0 as /devices/platform/AMDI0010:00/i2c-0/i2c-GXTP5140:00/0018:27C6:01E0.0001/input/input11
> [    2.137921] hid-multitouch 0018:27C6:01E0.0001: input,hidraw0: I2C HID v1.00 Mouse [GXTP5140:00 27C6:01E0] on i2c-GXTP5140:00
> 
> Hardware is a Lenovo ThinkPad L15 Gen 4.
> 
> The problem goes away when reverting this commit:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/hid/hid-multitouch.c?id=251efae73bd46b097deec4f9986d926813aed744

Thx for the report. Is this a 6.6.y specific thing, or does it happen
with 6.12-rc6 or later as well?  And if it does: does the revert fix it
there, too?

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

Re: [REGRESSION] ThinkPad L15 Gen 4 touchpad no longer works

[Ulrich Müller]

>>>>> On Sat, 09 Nov 2024, Linux regression tracking (Thorsten Leemhuis) wrote:

> On 03.11.24 09:24, Ulrich Müller wrote:
>> After upgrading from 6.6.52 to 6.6.58, tapping on the touchpad stopped
>> working. The problem is still present in 6.6.59.
>> 
>> I see the following in dmesg output; the first line was not there
>> previously:
>> 
>> [    2.129282] hid-multitouch 0018:27C6:01E0.0001: The byte is not expected for fixing the report descriptor. It's possible that the touchpad firmware is not suitable for applying the fix. got: 9
>> [    2.137479] input: GXTP5140:00 27C6:01E0 as /devices/platform/AMDI0010:00/i2c-0/i2c-GXTP5140:00/0018:27C6:01E0.0001/input/input10
>> [    2.137680] input: GXTP5140:00 27C6:01E0 as /devices/platform/AMDI0010:00/i2c-0/i2c-GXTP5140:00/0018:27C6:01E0.0001/input/input11
>> [    2.137921] hid-multitouch 0018:27C6:01E0.0001: input,hidraw0: I2C HID v1.00 Mouse [GXTP5140:00 27C6:01E0] on i2c-GXTP5140:00
>> 
>> Hardware is a Lenovo ThinkPad L15 Gen 4.
>> 
>> The problem goes away when reverting this commit:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/hid/hid-multitouch.c?id=251efae73bd46b097deec4f9986d926813aed744

> Thx for the report. Is this a 6.6.y specific thing, or does it happen
> with 6.12-rc6 or later as well?  And if it does: does the revert fix it
> there, too?

It still happens with 6.12-rc6, and the revert fixes it.

Re: [REGRESSION] ThinkPad L15 Gen 4 touchpad no longer works

[Thorsten Leemhuis]

On 09.11.24 15:54, Ulrich Müller wrote:
>>>>>> On Sat, 09 Nov 2024, Linux regression tracking (Thorsten Leemhuis) wrote:
> 
>> On 03.11.24 09:24, Ulrich Müller wrote:
>>> After upgrading from 6.6.52 to 6.6.58, tapping on the touchpad stopped
>>> working. The problem is still present in 6.6.59.
>>>
>>> I see the following in dmesg output; the first line was not there
>>> previously:
>>>
>>> [    2.129282] hid-multitouch 0018:27C6:01E0.0001: The byte is not expected for fixing the report descriptor. It's possible that the touchpad firmware is not suitable for applying the fix. got: 9
>>> [    2.137479] input: GXTP5140:00 27C6:01E0 as /devices/platform/AMDI0010:00/i2c-0/i2c-GXTP5140:00/0018:27C6:01E0.0001/input/input10
>>> [    2.137680] input: GXTP5140:00 27C6:01E0 as /devices/platform/AMDI0010:00/i2c-0/i2c-GXTP5140:00/0018:27C6:01E0.0001/input/input11
>>> [    2.137921] hid-multitouch 0018:27C6:01E0.0001: input,hidraw0: I2C HID v1.00 Mouse [GXTP5140:00 27C6:01E0] on i2c-GXTP5140:00
>>>
>>> Hardware is a Lenovo ThinkPad L15 Gen 4.
>>>
>>> The problem goes away when reverting this commit:
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/hid/hid-multitouch.c?id=251efae73bd46b097deec4f9986d926813aed744
> 
>> Thx for the report. Is this a 6.6.y specific thing, or does it happen
>> with 6.12-rc6 or later as well?  And if it does: does the revert fix it
>> there, too?
> 
> It still happens with 6.12-rc6, and the revert fixes it.

He Lugang, in case you missed it: the culprit (251efae73bd46b ("HID:
multitouch: Add support for lenovo Y9000P Touchpad") [v6.12-rc1]) is a
commit of yours. At it was already backported to various stable series,
so it would be good to fix this rather sooner than later.

Ciao, Thorsten

Re: [REGRESSION] ThinkPad L15 Gen 4 touchpad no longer works

[Benjamin Tissoires]

On Nov 03 2024, Ulrich Müller wrote:
> After upgrading from 6.6.52 to 6.6.58, tapping on the touchpad stopped
> working. The problem is still present in 6.6.59.
> 
> I see the following in dmesg output; the first line was not there
> previously:
> 
> [    2.129282] hid-multitouch 0018:27C6:01E0.0001: The byte is not expected for fixing the report descriptor. It's possible that the touchpad firmware is not suitable for applying the fix. got: 9
> [    2.137479] input: GXTP5140:00 27C6:01E0 as /devices/platform/AMDI0010:00/i2c-0/i2c-GXTP5140:00/0018:27C6:01E0.0001/input/input10
> [    2.137680] input: GXTP5140:00 27C6:01E0 as /devices/platform/AMDI0010:00/i2c-0/i2c-GXTP5140:00/0018:27C6:01E0.0001/input/input11
> [    2.137921] hid-multitouch 0018:27C6:01E0.0001: input,hidraw0: I2C HID v1.00 Mouse [GXTP5140:00 27C6:01E0] on i2c-GXTP5140:00
> 
> Hardware is a Lenovo ThinkPad L15 Gen 4.
> 
> The problem goes away when reverting this commit:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/hid/hid-multitouch.c?id=251efae73bd46b097deec4f9986d926813aed744
> 
> See also Gentoo bug report: https://bugs.gentoo.org/942797

He Lugang,

It's been 3 weeks since this regression was reported and we haven't
heard back from you. It's clear that the patch mentioned here is too
gready and needs tuning to only apply to the firmware which needs the
fix.

Could you quickly submit a fix that checks that the device is indeed
requiring the fix (and thus the class
MT_CLS_WIN_8_FORCE_MULTI_INPUT_NSMU) and if not, keep the default class?

Cheers,
Benjamin

Re: [REGRESSION] ThinkPad L15 Gen 4 touchpad no longer works

[Jiri Kosina]

On Mon, 25 Nov 2024, Benjamin Tissoires wrote:

> On Nov 03 2024, Ulrich Müller wrote:
> > After upgrading from 6.6.52 to 6.6.58, tapping on the touchpad stopped
> > working. The problem is still present in 6.6.59.
> > 
> > I see the following in dmesg output; the first line was not there
> > previously:
> > 
> > [    2.129282] hid-multitouch 0018:27C6:01E0.0001: The byte is not expected for fixing the report descriptor. It's possible that the touchpad firmware is not suitable for applying the fix. got: 9
> > [    2.137479] input: GXTP5140:00 27C6:01E0 as /devices/platform/AMDI0010:00/i2c-0/i2c-GXTP5140:00/0018:27C6:01E0.0001/input/input10
> > [    2.137680] input: GXTP5140:00 27C6:01E0 as /devices/platform/AMDI0010:00/i2c-0/i2c-GXTP5140:00/0018:27C6:01E0.0001/input/input11
> > [    2.137921] hid-multitouch 0018:27C6:01E0.0001: input,hidraw0: I2C HID v1.00 Mouse [GXTP5140:00 27C6:01E0] on i2c-GXTP5140:00
> > 
> > Hardware is a Lenovo ThinkPad L15 Gen 4.
> > 
> > The problem goes away when reverting this commit:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/hid/hid-multitouch.c?id=251efae73bd46b097deec4f9986d926813aed744
> > 
> > See also Gentoo bug report: https://bugs.gentoo.org/942797
> 
> He Lugang,
> 
> It's been 3 weeks since this regression was reported and we haven't
> heard back from you. It's clear that the patch mentioned here is too
> gready and needs tuning to only apply to the firmware which needs the
> fix.
> 
> Could you quickly submit a fix that checks that the device is indeed
> requiring the fix (and thus the class
> MT_CLS_WIN_8_FORCE_MULTI_INPUT_NSMU) and if not, keep the default class?

Lugang, have you perhaps missed this one?

If we don't hear from you by the end of this week, I'll revert the patch 
(unless there is someone else who has access to the device and cook up a 
tested fw-dependent patch).

Thanks,

-- 
Jiri Kosina
SUSE Labs

Re: "[REGRESSION] ThinkPad L15 Gen 4 touchpad no longer works"

[WangYuli]

Thanks to Jeffbai's reminder. And I apologize for the late reply to the bug report
by Ulrich Müller.

He Lugang has left our company, which explains why he hasn't responded to your
emails as they were sent to his old corporate email address.

As his good friend, former colleague, and one of kernel maintainer for another Linux
distribution, I understand the urgency of this issue.

I'm currently testing with the affected hardware and will provide a patch soon.

Regarding the temporary workaround for Gentoo, while reverting the previous changes
is a viable temporary solution, I'm committed to providing a more comprehensive fix
that supports both Lenovo ThinkPad L15 Gen 4 and Lenovo Y9000P 2024.

Thank you all for your patience and understanding.

Thanks,
--
WangYuli

Re: "[REGRESSION] ThinkPad L15 Gen 4 touchpad no longer works"

[WangYuli]

Thanks to everyone's help, we've been able to determine that the initial
report about the 27c6:01e0 touchpad was a misunderstanding.

The 27C6:01E0 touchpad doesn't require the workaround and applying it
would actually break functionality.

The initial report came from a BBS forum, but we suspect the information
provided by the forum user may be incorrect which could happen sometimes. [1]

Further investigation showed that the Lenovo Y9000P 2024 doesn't even
use a Goodix touchpad. [2]

For the broader issue of 27c6:01e0 being unusable on some devices, it
just need to address it with a libinput quirk.

In conclusion, we should revert this commit, which is the best solution.

Thank you all again for the bug report and your patience and support.


[1]. https://bbs.deepin.org/post/276451
[2]. https://linux-hardware.org/?probe=35b1e770a7


Thanks,
-- 
WangYuli

Re: "[REGRESSION] ThinkPad L15 Gen 4 touchpad no longer works"

[Jiri Kosina]

On Tue, 10 Dec 2024, WangYuli wrote:

> Thanks to Jeffbai's reminder. And I apologize for the late reply to the bug report
> by Ulrich Müller.
> 
> He Lugang has left our company, which explains why he hasn't responded to your
> emails as they were sent to his old corporate email address.
> 
> As his good friend, former colleague, and one of kernel maintainer for another Linux
> distribution, I understand the urgency of this issue.
> 
> I'm currently testing with the affected hardware and will provide a patch soon.
> 
> Regarding the temporary workaround for Gentoo, while reverting the previous changes
> is a viable temporary solution, I'm committed to providing a more comprehensive fix
> that supports both Lenovo ThinkPad L15 Gen 4 and Lenovo Y9000P 2024.
> 
> Thank you all for your patience and understanding.

Thanks for looking into this. I have now queued the revert in 
hid.git#for-6.13/upstream-fixes

-- 
Jiri Kosina
SUSE Labs

Re: "[REGRESSION] ThinkPad L15 Gen 4 touchpad no longer works"

[WangYuli]

[-- Attachment #1.1.1: Type: text/plain, Size: 341 bytes --]

On 2024/12/12 16:56, Jiri Kosina wrote:

> Thanks for looking into this. I have now queued the revert in
> hid.git#for-6.13/upstream-fixes
>
Hmm,
The original commit included a crucial fix for a typo where 01E8 was 
incorrectly used instead of 01E9. We need to make sure we keep that 
correction.

Please be aware,
-- 
WangYuli

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 645 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

Re: "[REGRESSION] ThinkPad L15 Gen 4 touchpad no longer works"

[Jiri Kosina]

On Thu, 12 Dec 2024, WangYuli wrote:

> > Thanks for looking into this. I have now queued the revert in
> > hid.git#for-6.13/upstream-fixes
> >
> Hmm,
> The original commit included a crucial fix for a typo where 01E8 was
> incorrectly used instead of 01E9. We need to make sure we keep that
> correction.

Sadly that information was somehow missing from the changelog.

I will reintroduce that as a separate fix, thanks for noticing.

-- 
Jiri Kosina
SUSE Labs

Re: "[REGRESSION] ThinkPad L15 Gen 4 touchpad no longer works"

[Ulrich Müller]

>>>>> On Thu, 12 Dec 2024, Jiri Kosina wrote:

> On Tue, 10 Dec 2024, WangYuli wrote:
>> Thanks to Jeffbai's reminder. And I apologize for the late reply to the bug report
>> by Ulrich Müller.
>> 
>> He Lugang has left our company, which explains why he hasn't responded to your
>> emails as they were sent to his old corporate email address.
>> 
>> As his good friend, former colleague, and one of kernel maintainer for another Linux
>> distribution, I understand the urgency of this issue.
>> 
>> I'm currently testing with the affected hardware and will provide a patch soon.
>> 
>> Regarding the temporary workaround for Gentoo, while reverting the previous changes
>> is a viable temporary solution, I'm committed to providing a more comprehensive fix
>> that supports both Lenovo ThinkPad L15 Gen 4 and Lenovo Y9000P 2024.
>> 
>> Thank you all for your patience and understanding.

> Thanks for looking into this. I have now queued the revert in 
> hid.git#for-6.13/upstream-fixes

After the revert, there are now duplicate entries in hid-multitouch.c
lines 2082-2048 and 2085-2087 ("Goodix GT7868Q devices").

Maybe this should be fixed in a follow-up commit? It looks like a
copy/paste error in commit c8000deb68365b461b324d68c7ea89d730f0bb85.
CCing its author.

Re: "[REGRESSION] ThinkPad L15 Gen 4 touchpad no longer works"

[Jiri Kosina]

On Thu, 12 Dec 2024, Ulrich Müller wrote:

> After the revert, there are now duplicate entries in hid-multitouch.c
> lines 2082-2048 and 2085-2087 ("Goodix GT7868Q devices").
> 
> Maybe this should be fixed in a follow-up commit? It looks like a
> copy/paste error in commit c8000deb68365b461b324d68c7ea89d730f0bb85.
> CCing its author.

Yeah, WangYuli also noticed that earlier in this thread. Should be fixed 
now by [1].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-6.13/upstream-fixes&id=8ade5e05bd094485ce370fad66a6a3fb6f50bfbc

-- 
Jiri Kosina
SUSE Labs