From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f43.google.com (mail-yx1-f43.google.com [74.125.224.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 628E93B42C4 for ; Fri, 28 Aug 2026 20:26:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787948791; cv=none; b=QfL5TKtfMGOyniLwE0TOtVRYmX8wFpcxfqh781Dt4QNDaS7acUyAAXynBgah01a+3ikgyVpaZbRZnwJuairRuPyX4/5fiAMt0AjQbY2iNWpyZtyHWeP5dvmrWsYPFTRnHeWoOTmhDtEs99fidiVfiRX9gpvNwTiRgc+AkxMIr7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787948791; c=relaxed/simple; bh=lFpFtYv6iQcb7S5D9sDFzWR132x+i45bvQJN5YmB7Zg=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=QBXRRKYv8vsIvf/0IoRUz7tjtiVOht4YCgDAPBg286Ok/tIs9o3k+yGvyD79j4QBqy30Msn0Dr+iEtbJBqrXsVEa6oHv781f7kkPZQN1zpR+T5bnJvqVzWe0V4lq87v6jDc3CKWvwGLL+ja6LuYt3ilCLroWTE4GUkqoT/iNH5w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bHe0a0U7; arc=none smtp.client-ip=74.125.224.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bHe0a0U7" Received: by mail-yx1-f43.google.com with SMTP id 956f58d0204a3-66c7e3a2332so1393720d50.2 for ; Fri, 28 Aug 2026 13:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787948789; x=1788553589; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:subject :references:in-reply-to:message-id:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=tGVauGPoAYu5wHetzl3LM6n1Jp84rQMdvhVyIaoVuCg=; b=bHe0a0U73dR7D66cNuxInO9OFEprZe1WVNp+4DAFZ9NnedJtyWEwJuLcS1ku0nmxBj fy6/vZ/U3YSe8+1sNYbnBCH1iaX/xftHMO5lA7VxCFBViX/qdnw+I7DqsV4IMZgMggCw BHypkkkzust1/SFpxQ5EKRaNFUHys4hAyYI+pni8StKM+L+SQhTSQhGKEoUvdvDSCihf KMKeZc+e/KNuIeZhxvMas31N51ZAZJg//CAy5bK22x/0qDYA9QLuv7rxsO5eAnSPpPCq /G9IcSl6VhG57fhxWpuu58AGxfyMutW0mYdcTcUc/LQOy1Y5nLVWWKD41k9GTBvpcwMJ 569A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787948789; x=1788553589; h=content-transfer-encoding:content-type:mime-version:subject :references:in-reply-to:message-id:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tGVauGPoAYu5wHetzl3LM6n1Jp84rQMdvhVyIaoVuCg=; b=l52eWtsC2Em7Umm8BWOX3BWljnSWEMPI1sIxI+svExLt/GyH46zXfYsYRrYy+W0Bg5 iJYcNLoYLNFaZQVfv4+gCMPUd7Z4zomPUDc13tqThtdhUufnKKJp9ylNK2sNnhuLw0Dr nOyvRFtOudhSk4a7qLfuKxFFQjuL8mQLd/Ht6AGhpYJdVkxFS6LFnh6YyeEEOeLmqmn/ +0jZRn5k68BYKIGIioWWTO0Zc57izQqdKU8jeTHB9/hYtXfeWOZ5yLD8TYirSIaym54s HbN1VMRPBk+98X4JyhuG3mT7DpWIgXSDsp5SlAcHPQ8aSNhsDp8AVsEVYY3HeqPkyvWT IHRg== X-Forwarded-Encrypted: i=1; AKwUvBz5ml/u/+n6sgzDqZI5HxtmfFz3n7YLSmv/kAwQcxLid3kxuonEL07zBAAEI/IINCYtC8DCPcE=@vger.kernel.org X-Gm-Message-State: AFuF++l+XcwSOkJh7SYYWnQbEpYK9LPSlm9A1Kwo6jcSqp4DQVSbFrDZ toT3gRlaw0XIfkg3w/lPCMATEPV8L7bs0LpqfN8FM9A+1/MZxyzlqhyn X-Gm-Gg: AYBFou3hVYenVbZFZP93q5IH7WXqXqcHifWLRIJ0L780xY/16FQrU8qg38CycHFLsDG qi7lq34vpMnazfUHIGA5+e5cdkzFIykVZx+a3DoH8Ay53344eQIS9a1s3KqY6YT6MGXycJfZHoz 9gJpZd3PEt71gyX/iVBxM48mEOTmDeyndkGS8vA+UVukvxWAHrMn0Go9ihxlpHVjCfzB6bC8NjR hZSSFlgl3kdDL6DEHC7ywoVDAk7kZpfXfl252x8q+T8FXyWYsR91Nmi+Q4DE7UoMR6ekBAQOWcf vXCzPH8UB921BoxaV5QuyaqoUBhCMmRUOic6crPvGDvOzGdLsvHPXR7MDNjEcqTEodIKzqFtj5F luBufHfAUIMSGLF77VN8XVGpX9XRpVTud9V8AffYX7+UhWNbKm/3comIhv6XNAQn3Rf4VMhdI+0 8OSo/iIHxeXIh8P+oT4szW8m6IZYvSBWrjM8C7P1zg8SkG+ami1TOLvaPXKli/uvCmeeyxDabHm zNS1F35QyJojDbHW7bACcT+4UHejk3O29JyHHHLcngVA9igWcCbfg== X-Received: by 2002:a53:bc8b:0:b0:66d:117c:6cfb with SMTP id 956f58d0204a3-66e4c731f0dmr2380958d50.31.1787948789271; Fri, 28 Aug 2026 13:26:29 -0700 (PDT) Received: from gmail.com (234.207.85.34.bc.googleusercontent.com. [34.85.207.234]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-66e4eb66e45sm1469968d50.9.2026.08.28.13.26.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Aug 2026 13:26:28 -0700 (PDT) Date: Fri, 28 Aug 2026 16:26:27 -0400 From: Willem de Bruijn To: Qihang , Willem de Bruijn Cc: Hangbin Liu , jv@jvosburgh.net, jiri@resnulli.us, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, willemb@google.com, netdev@vger.kernel.org, stable@vger.kernel.org Message-ID: In-Reply-To: References: <20260824021802.90369-1-q.h.hack.winter@gmail.com> Subject: Re: [PATCH net 1/2] bonding: reject frames with insufficient headroom in bond_header_create Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Qihang wrote: > Yeah, agreed on steady state. > > One thing to flag: packet_snd snapshots dev->hard_header_len at > af_packet.c:3023 (no lock) but pushes the header at :3059 onto whatever > curr_active_slave is then. A concurrent enslave that bumps it in between > -- first non-Ethernet slave 14->24, or a bigger-header failover -- can It does appear that all slaves need to be of the same type, in bond_enslave: if (!bond_has_slaves(bond)) { ... } else if (bond_dev->type != slave_dev->type) { SLAVE_NL_ERR(bond_dev, slave_dev, extack, "Device type is different from other slaves"); } > leave the in-flight frame short and trip skb_under_panic (oops/panic, > not silent corruption; local DoS for a privileged user). But the same type can still create different hard_header_len, e.g., with GRE devices. I had expected that bond slave changes, such as bond_enslave, would flush the stack using synchronize_net(). For instance when updating the valid slaves for non-primary bonds, in bond_set_slave_arr. But it does appear that a packet may see two different bond->hard_header_len in a single packet_snd. > Happy to drop v1, or hand over the create-time check if you want it closed. Much appreciate your help on this, Qihang.