stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tools: usb: ffs-test: Fix build failure
@ 2013-02-20 23:57 maxin.john
  2013-02-21  0:06 ` Greg KH
  2013-02-21  6:42 ` Michal Nazarewicz
  0 siblings, 2 replies; 5+ messages in thread
From: maxin.john @ 2013-02-20 23:57 UTC (permalink / raw)
  To: gregkh, mina86
  Cc: matt.fleming, matthias.fend, balbi, linux-usb, hpa, linux-kernel,
	stable, Maxin B. John

From: "Maxin B. John" <maxin.john@enea.com>

Fixes this build failure:
gcc -Wall -Wextra -g -lpthread -I../include -o testusb testusb.c
gcc -Wall -Wextra -g -lpthread -I../include -o ffs-test ffs-test.c
In file included from ffs-test.c:41:0:
../../include/linux/usb/functionfs.h:4:39: fatal error:
uapi/linux/usb/functionfs.h: No such file or directory
compilation terminated.
make: *** [ffs-test] Error 1

Signed-off-by: Maxin B. John <maxin.john@enea.com>
---
 tools/usb/ffs-test.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/usb/ffs-test.c b/tools/usb/ffs-test.c
index 8674b9e..fe1e66b 100644
--- a/tools/usb/ffs-test.c
+++ b/tools/usb/ffs-test.c
@@ -38,7 +38,7 @@
 #include <unistd.h>
 #include <tools/le_byteshift.h>
 
-#include "../../include/linux/usb/functionfs.h"
+#include "../../include/uapi/linux/usb/functionfs.h"
 
 
 /******************** Little Endian Handling ********************************/
-- 
1.7.7


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] tools: usb: ffs-test: Fix build failure
  2013-02-20 23:57 [PATCH] tools: usb: ffs-test: Fix build failure maxin.john
@ 2013-02-21  0:06 ` Greg KH
  2013-02-21  0:22   ` Maxin B. John
  2013-02-21  6:42 ` Michal Nazarewicz
  1 sibling, 1 reply; 5+ messages in thread
From: Greg KH @ 2013-02-21  0:06 UTC (permalink / raw)
  To: maxin.john
  Cc: mina86, matt.fleming, matthias.fend, balbi, linux-usb, hpa,
	linux-kernel, stable, Maxin B. John

On Thu, Feb 21, 2013 at 01:57:51AM +0200, maxin.john@gmail.com wrote:
> From: "Maxin B. John" <maxin.john@enea.com>
> 
> Fixes this build failure:
> gcc -Wall -Wextra -g -lpthread -I../include -o testusb testusb.c
> gcc -Wall -Wextra -g -lpthread -I../include -o ffs-test ffs-test.c
> In file included from ffs-test.c:41:0:
> ../../include/linux/usb/functionfs.h:4:39: fatal error:
> uapi/linux/usb/functionfs.h: No such file or directory
> compilation terminated.
> make: *** [ffs-test] Error 1

This is a build failure where, 3.8, or linux-next, or somewhere else?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] tools: usb: ffs-test: Fix build failure
  2013-02-21  0:06 ` Greg KH
@ 2013-02-21  0:22   ` Maxin B. John
  2013-02-21  6:44     ` Michal Nazarewicz
  0 siblings, 1 reply; 5+ messages in thread
From: Maxin B. John @ 2013-02-21  0:22 UTC (permalink / raw)
  To: Greg KH
  Cc: mina86, matt.fleming, matthias.fend, balbi, linux-usb, hpa,
	linux-kernel, stable, Maxin B. John

Hi,

On Thu, Feb 21, 2013 at 2:06 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, Feb 21, 2013 at 01:57:51AM +0200, maxin.john@gmail.com wrote:
>> From: "Maxin B. John" <maxin.john@enea.com>
>>
>> Fixes this build failure:
>> gcc -Wall -Wextra -g -lpthread -I../include -o testusb testusb.c
>> gcc -Wall -Wextra -g -lpthread -I../include -o ffs-test ffs-test.c
>> In file included from ffs-test.c:41:0:
>> ../../include/linux/usb/functionfs.h:4:39: fatal error:
>> uapi/linux/usb/functionfs.h: No such file or directory
>> compilation terminated.
>> make: *** [ffs-test] Error 1
>
> This is a build failure where, 3.8, or linux-next, or somewhere else?

It is in 3.8

> thanks,
>
> greg k-h

Best Regards,
Maxin

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] tools: usb: ffs-test: Fix build failure
  2013-02-20 23:57 [PATCH] tools: usb: ffs-test: Fix build failure maxin.john
  2013-02-21  0:06 ` Greg KH
@ 2013-02-21  6:42 ` Michal Nazarewicz
  1 sibling, 0 replies; 5+ messages in thread
From: Michal Nazarewicz @ 2013-02-21  6:42 UTC (permalink / raw)
  To: maxin.john, gregkh
  Cc: matt.fleming, matthias.fend, balbi, linux-usb, hpa, linux-kernel,
	stable, Maxin B. John

[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]

On Thu, Feb 21 2013, maxin.john@gmail.com wrote:
> From: "Maxin B. John" <maxin.john@enea.com>
>
> Fixes this build failure:
> gcc -Wall -Wextra -g -lpthread -I../include -o testusb testusb.c
> gcc -Wall -Wextra -g -lpthread -I../include -o ffs-test ffs-test.c
> In file included from ffs-test.c:41:0:
> ../../include/linux/usb/functionfs.h:4:39: fatal error:
> uapi/linux/usb/functionfs.h: No such file or directory
> compilation terminated.
> make: *** [ffs-test] Error 1
>
> Signed-off-by: Maxin B. John <maxin.john@enea.com>

Acked-by: Michal Nazarewicz <mina86@mina86.com>

> ---
>  tools/usb/ffs-test.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/usb/ffs-test.c b/tools/usb/ffs-test.c
> index 8674b9e..fe1e66b 100644
> --- a/tools/usb/ffs-test.c
> +++ b/tools/usb/ffs-test.c
> @@ -38,7 +38,7 @@
>  #include <unistd.h>
>  #include <tools/le_byteshift.h>
>  
> -#include "../../include/linux/usb/functionfs.h"
> +#include "../../include/uapi/linux/usb/functionfs.h"
>  
>  
>  /******************** Little Endian Handling ********************************/
> -- 
> 1.7.7
>

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--

[-- Attachment #2.1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2.2: Type: application/pgp-signature, Size: 835 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] tools: usb: ffs-test: Fix build failure
  2013-02-21  0:22   ` Maxin B. John
@ 2013-02-21  6:44     ` Michal Nazarewicz
  0 siblings, 0 replies; 5+ messages in thread
From: Michal Nazarewicz @ 2013-02-21  6:44 UTC (permalink / raw)
  To: Maxin B. John, Greg KH
  Cc: matt.fleming, matthias.fend, balbi, linux-usb, hpa, linux-kernel,
	stable, Maxin B. John

[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]

On Thu, Feb 21 2013, Maxin B. John wrote:
> Hi,
>
> On Thu, Feb 21, 2013 at 2:06 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
>> On Thu, Feb 21, 2013 at 01:57:51AM +0200, maxin.john@gmail.com wrote:
>>> From: "Maxin B. John" <maxin.john@enea.com>
>>>
>>> Fixes this build failure:
>>> gcc -Wall -Wextra -g -lpthread -I../include -o testusb testusb.c
>>> gcc -Wall -Wextra -g -lpthread -I../include -o ffs-test ffs-test.c
>>> In file included from ffs-test.c:41:0:
>>> ../../include/linux/usb/functionfs.h:4:39: fatal error:
>>> uapi/linux/usb/functionfs.h: No such file or directory
>>> compilation terminated.
>>> make: *** [ffs-test] Error 1
>>
>> This is a build failure where, 3.8, or linux-next, or somewhere else?
>
> It is in 3.8

This also happens in 3.7.  [commit
5e1ddb481776a487b15b40579a000b279ce527c9: UAPI: (Scripted) Disintegrate
include/linux/usb] is the culprit.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--

[-- Attachment #2.1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2.2: Type: application/pgp-signature, Size: 835 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-02-21  6:44 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-20 23:57 [PATCH] tools: usb: ffs-test: Fix build failure maxin.john
2013-02-21  0:06 ` Greg KH
2013-02-21  0:22   ` Maxin B. John
2013-02-21  6:44     ` Michal Nazarewicz
2013-02-21  6:42 ` Michal Nazarewicz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).