From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f175.google.com ([209.85.212.175]:36180 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934509AbbGHOBE convert rfc822-to-8bit (ORCPT ); Wed, 8 Jul 2015 10:01:04 -0400 Received: by widjy10 with SMTP id jy10so218097867wid.1 for ; Wed, 08 Jul 2015 07:01:03 -0700 (PDT) From: Michal Nazarewicz To: Krzysztof Opasiak , balbi@ti.com Cc: stable@vger.kernel.org, david.fisher1@synopsys.com, gregkh@linuxfoundation.org, andrzej.p@samsung.com, m.szyprowski@samsung.com, linux-usb@vger.kernel.org, Krzysztof Opasiak Subject: Re: [PATCH v3 5/5] usb: gadget: mass_storage: Warn if LUNs ids are not contiguous In-Reply-To: <1436281065-32407-6-git-send-email-k.opasiak@samsung.com> References: <1436281065-32407-1-git-send-email-k.opasiak@samsung.com> <1436281065-32407-6-git-send-email-k.opasiak@samsung.com> Date: Wed, 08 Jul 2015 16:01:00 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: stable-owner@vger.kernel.org List-ID: On Tue, Jul 07 2015, Krzysztof Opasiak wrote: > According to mass storage specification: > > "Logical Unit Numbers on the device shall be numbered contiguously > starting from LUN 0 to a maximum LUN of 15 (Fh)" > > So let's at least print a warning message that LUNs ids should be > contiguous. > > Signed-off-by: Krzysztof Opasiak Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/function/f_mass_storage.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c > index 5fcd9a0..69167ad 100644 > --- a/drivers/usb/gadget/function/f_mass_storage.c > +++ b/drivers/usb/gadget/function/f_mass_storage.c > @@ -3042,6 +3042,13 @@ static int fsg_bind(struct usb_configuration *c, struct usb_function *f) > return -EINVAL; > } > > + for (i = 0; i < ARRAY_SIZE(common->luns); ++i) > + if (!common->luns[i]) > + break; > + > + if (ret != i - 1) > + pr_err("LUN ids should be contiguous.\n"); > + > opts = fsg_opts_from_func_inst(f->fi); > if (!opts->no_configfs) { > ret = fsg_common_set_cdev(fsg->common, c->cdev, > -- > 1.7.9.5 > -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------ooO--(_)--Ooo--