From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D2C6C43381 for ; Wed, 27 Feb 2019 14:50:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3AABE20863 for ; Wed, 27 Feb 2019 14:50:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="e4nKmGib" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730052AbfB0Oud (ORCPT ); Wed, 27 Feb 2019 09:50:33 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:35512 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726590AbfB0Oud (ORCPT ); Wed, 27 Feb 2019 09:50:33 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1REhlDF134357; Wed, 27 Feb 2019 14:50:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=//0/bPBHLujJvrNXa+QBG5OXqKaLhig5rFiksfvErsU=; b=e4nKmGib/sa1bXaEb2McnfV5B9mlGsxaEj+tZYO04al7uzj+/zvwgJ96q31L2yPdNIGC dX6wC7MAeWKLmbB4YkUvhVY/ZwhkYY5DZsjK/GTGAiR7GVN0pAHQhfPpTD2V05POa0vW uyMEAwsKrLUCKAmh3KzK5BzAZxkOUWPcXbmfAdHJbZd+nSMmnbWG5+IIBZVLcaI4VWdU C9P8vA/ejHorwlei7/NJSkHp+s/Tdx91q+O1vyis8ehnidYPkSPeMr39a85noYKMcmpG IKfe97P2+gEedSji8YJuViswt3LyjRws3BspWdwQ/lRL6bzx1zdXZIZ2D+QDXgR+rfJY RQ== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2qtwkub9tg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Feb 2019 14:50:17 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x1REoBUq009473 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Feb 2019 14:50:12 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x1REoBoQ024796; Wed, 27 Feb 2019 14:50:11 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 27 Feb 2019 06:50:11 -0800 To: Kashyap Desai Cc: Hannes Reinecke , Christoph Hellwig , Sreekanth Reddy , linux-scsi , Sathya Prakash , Suganath Prabu Subramani , stable@vger.kernel.org Subject: Re: [PATCH v1] mpt3sas: Use driver scsi lookup to track outstanding IOs From: "Martin K. Petersen" Organization: Oracle Corporation References: <1550751105-46065-1-git-send-email-sreekanth.reddy@broadcom.com> <61a8f703-3f20-b777-08b9-54ae34dffa59@suse.de> <0dfb09ca-8723-3a3c-a6a8-c643856c57e3@suse.de> <20190226143313.GA23865@infradead.org> <6f94a905-45c9-4a77-bbb6-9669197e8d8f@suse.de> Date: Wed, 27 Feb 2019 09:50:08 -0500 In-Reply-To: (Kashyap Desai's message of "Tue, 26 Feb 2019 21:35:10 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9179 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902270100 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Kashyap, > Primary drawback of using "blk_mq_tagset_busy_iter" is API is only for > blk-mq and it is not available for all the kernel with blk-mq > support. We have seen multiple failures from customer and those > kernels does not support blk_mq_tagset_busy_iter. In fact, blk-mq and > non-mq stack is alive in many Linux distribution and customer is using > those. I'm afraid the burden falls upon Broadcom to manage enablement patches for older kernels. So the non-MQ/non-tagset-busy-iter cases are not particularly relevant for the discussion here. Let's focus on getting some usable plumbing that drivers can use to abort oustanding tags. -- Martin K. Petersen Oracle Linux Engineering