From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Artem Savkov <asavkov@redhat.com>
Cc: hare@suse.de, axboe@fb.com, hch@lst.de,
martin.petersen@oracle.com,
Bart Van Assche <Bart.VanAssche@sandisk.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] Use ctlr directly in rdac_failover_get()
Date: Tue, 23 May 2017 21:55:19 -0400 [thread overview]
Message-ID: <yq160grxblk.fsf@oracle.com> (raw)
In-Reply-To: <1495267090-8591-1-git-send-email-asavkov@redhat.com> (Artem Savkov's message of "Sat, 20 May 2017 09:58:10 +0200")
Artem,
> rdac_failover_get references struct rdac_controller as
> ctlr->ms_sdev->handler_data->ctlr for no apparent reason. Besides being
> inefficient this also introduces a null-pointer dereference as
> send_mode_select() sets ctlr->ms_sdev to NULL before calling
> rdac_failover_get():
Applied to 4.12/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-05-24 1:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1495232608.2581.3.camel@sandisk.com>
2017-05-20 7:58 ` [PATCH v2] Use ctlr directly in rdac_failover_get() Artem Savkov
2017-05-21 6:54 ` Christoph Hellwig
2017-05-24 1:55 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq160grxblk.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=asavkov@redhat.com \
--cc=axboe@fb.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).