From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: David Disseldorp <ddiss@suse.de>
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v3] target: fix truncated PR-in ReadKeys response
Date: Tue, 19 Jun 2018 21:37:35 -0400 [thread overview]
Message-ID: <yq1d0wmfdb4.fsf@oracle.com> (raw)
In-Reply-To: <20180619155824.15388-1-ddiss@suse.de> (David Disseldorp's message of "Tue, 19 Jun 2018 17:58:24 +0200")
David,
> SPC5r17 states that the contents of the ADDITIONAL LENGTH field are not
> altered based on the allocation length, so always calculate and pack the
> full key list length even if the list itself is truncated.
>
> According to Maged:
> Yes it fixes the "Storage Spaces Persistent Reservation" test in the
> Windows 2016 Server Failover Cluster validation suites when having
> many connections that result in more than 8 registrations. I tested
> your patch on 4.17 with iblock.
>
> This behaviour can be tested using the libiscsi PrinReadKeys.Truncate
> test.
Applied to 4.18/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2018-06-20 1:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180619140216.23077c60@suse.de>
2018-06-19 15:58 ` [PATCH v3] target: fix truncated PR-in ReadKeys response David Disseldorp
2018-06-20 1:37 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1d0wmfdb4.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=ddiss@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).