* [PATCH v2] crypto: algapi - Avoid spurious modprobe on LOADED [not found] <20200407051744.GA13037@gondor.apana.org.au> @ 2020-04-07 6:02 ` Eric Biggers 2020-04-07 17:26 ` Martin K. Petersen 2020-04-16 6:52 ` Herbert Xu 0 siblings, 2 replies; 3+ messages in thread From: Eric Biggers @ 2020-04-07 6:02 UTC (permalink / raw) To: linux-crypto; +Cc: stable, Martin K . Petersen From: Eric Biggers <ebiggers@google.com> Currently after any algorithm is registered and tested, there's an unnecessary request_module("cryptomgr") even if it's already loaded. Also, CRYPTO_MSG_ALG_LOADED is sent twice, and thus if the algorithm is "crct10dif", lib/crc-t10dif.c replaces the tfm twice rather than once. This occurs because CRYPTO_MSG_ALG_LOADED is sent using crypto_probing_notify(), which tries to load "cryptomgr" if the notification is not handled (NOTIFY_DONE). This doesn't make sense because "cryptomgr" doesn't handle this notification. Fix this by using crypto_notify() instead of crypto_probing_notify(). Fixes: dd8b083f9a5e ("crypto: api - Introduce notifier for new crypto algorithms") Cc: <stable@vger.kernel.org> # v4.20+ Cc: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Eric Biggers <ebiggers@google.com> --- crypto/algapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/algapi.c b/crypto/algapi.c index 69605e21af92..849254d7e627 100644 --- a/crypto/algapi.c +++ b/crypto/algapi.c @@ -403,7 +403,7 @@ static void crypto_wait_for_test(struct crypto_larval *larval) err = wait_for_completion_killable(&larval->completion); WARN_ON(err); if (!err) - crypto_probing_notify(CRYPTO_MSG_ALG_LOADED, larval); + crypto_notify(CRYPTO_MSG_ALG_LOADED, larval); out: crypto_larval_kill(&larval->alg); -- 2.26.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] crypto: algapi - Avoid spurious modprobe on LOADED 2020-04-07 6:02 ` [PATCH v2] crypto: algapi - Avoid spurious modprobe on LOADED Eric Biggers @ 2020-04-07 17:26 ` Martin K. Petersen 2020-04-16 6:52 ` Herbert Xu 1 sibling, 0 replies; 3+ messages in thread From: Martin K. Petersen @ 2020-04-07 17:26 UTC (permalink / raw) To: Eric Biggers; +Cc: linux-crypto, stable, Martin K . Petersen Eric, > Currently after any algorithm is registered and tested, there's an > unnecessary request_module("cryptomgr") even if it's already loaded. > Also, CRYPTO_MSG_ALG_LOADED is sent twice, and thus if the algorithm > is "crct10dif", lib/crc-t10dif.c replaces the tfm twice rather than > once. > > This occurs because CRYPTO_MSG_ALG_LOADED is sent using > crypto_probing_notify(), which tries to load "cryptomgr" if the > notification is not handled (NOTIFY_DONE). This doesn't make sense > because "cryptomgr" doesn't handle this notification. > > Fix this by using crypto_notify() instead of crypto_probing_notify(). Looks good to me. Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com> -- Martin K. Petersen Oracle Linux Engineering ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] crypto: algapi - Avoid spurious modprobe on LOADED 2020-04-07 6:02 ` [PATCH v2] crypto: algapi - Avoid spurious modprobe on LOADED Eric Biggers 2020-04-07 17:26 ` Martin K. Petersen @ 2020-04-16 6:52 ` Herbert Xu 1 sibling, 0 replies; 3+ messages in thread From: Herbert Xu @ 2020-04-16 6:52 UTC (permalink / raw) To: Eric Biggers; +Cc: linux-crypto, stable, Martin K . Petersen On Mon, Apr 06, 2020 at 11:02:40PM -0700, Eric Biggers wrote: > From: Eric Biggers <ebiggers@google.com> > > Currently after any algorithm is registered and tested, there's an > unnecessary request_module("cryptomgr") even if it's already loaded. > Also, CRYPTO_MSG_ALG_LOADED is sent twice, and thus if the algorithm is > "crct10dif", lib/crc-t10dif.c replaces the tfm twice rather than once. > > This occurs because CRYPTO_MSG_ALG_LOADED is sent using > crypto_probing_notify(), which tries to load "cryptomgr" if the > notification is not handled (NOTIFY_DONE). This doesn't make sense > because "cryptomgr" doesn't handle this notification. > > Fix this by using crypto_notify() instead of crypto_probing_notify(). > > Fixes: dd8b083f9a5e ("crypto: api - Introduce notifier for new crypto algorithms") > Cc: <stable@vger.kernel.org> # v4.20+ > Cc: Martin K. Petersen <martin.petersen@oracle.com> > Signed-off-by: Eric Biggers <ebiggers@google.com> > Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com> > --- > crypto/algapi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-16 6:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200407051744.GA13037@gondor.apana.org.au>
2020-04-07 6:02 ` [PATCH v2] crypto: algapi - Avoid spurious modprobe on LOADED Eric Biggers
2020-04-07 17:26 ` Martin K. Petersen
2020-04-16 6:52 ` Herbert Xu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).