From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Pavel Machek <pavel@ucw.cz>,
bvanassche@acm.org, hch@lst.de, hare@suse.de,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
torvalds@linux-foundation.org, stable@vger.kernel.org,
lwn@lwn.net, jslaby@suse.cz
Subject: Re: scsi_get_lba breakage in 5.10 -- Re: Linux 5.10.206
Date: Thu, 11 Jan 2024 21:21:00 -0500 [thread overview]
Message-ID: <yq1il3z5m4y.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <2024011121-unfailing-backroom-14e6@gregkh> (Greg Kroah-Hartman's message of "Thu, 11 Jan 2024 10:45:38 +0100")
Greg,
>> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
>> index 0c4bc42b55c2..3d3d139127ee 100644
>> --- a/drivers/scsi/scsi_error.c
>> +++ b/drivers/scsi/scsi_error.c
>> @@ -1069,6 +1069,7 @@ static int scsi_send_eh_cmnd(struct scsi_cmnd *scmd, unsigned char *cmnd,
>>
>> scsi_log_send(scmd);
>> scmd->scsi_done = scsi_eh_done;
>> + scmd->flags |= SCMD_LAST;
>>
>> /*
>> * Lock sdev->state_mutex to avoid that scsi_device_quiesce() can
>> @@ -2361,6 +2362,7 @@ scsi_ioctl_reset(struct scsi_device *dev, int __user *arg)
>> scsi_init_command(dev, scmd);
>> scmd->request = rq;
>> scmd->cmnd = scsi_req(rq)->cmd;
>> + scmd->flags |= SCMD_LAST;
>>
>> scmd->scsi_done = scsi_reset_provider_done_command;
>> memset(&scmd->sdb, 0, sizeof(scmd->sdb));
>
> Ok, I have now done this and will push out a -rc1 with these changes in
> it.
Yeah, no need to bring in all those PI updates with associated driver
changes just for this.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2024-01-12 2:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 14:42 Linux 5.10.206 Greg Kroah-Hartman
2024-01-05 14:42 ` Greg Kroah-Hartman
2024-01-09 12:15 ` scsi_get_lba breakage in 5.10 -- " Pavel Machek
2024-01-09 13:55 ` Martin K. Petersen
2024-01-10 9:15 ` Greg Kroah-Hartman
2024-01-11 9:45 ` Greg Kroah-Hartman
2024-01-12 2:21 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1il3z5m4y.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bvanassche@acm.org \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=lwn@lwn.net \
--cc=pavel@ucw.cz \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox